Bug 270165 - editors/neovim-gtk: new port
Summary: editors/neovim-gtk: new port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alan Somers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-13 00:13 UTC by Alan Somers
Modified: 2023-03-14 17:11 UTC (History)
1 user (show)

See Also:

Attachments
Adds the editors/neovim-gtk port (32.86 KB, patch)
2023-03-13 00:13 UTC, Alan Somers 		no flags Details | Diff
Responds to reviewer's comments. Cumulative with first patch. (9.26 KB, patch)
2023-03-13 19:06 UTC, Alan Somers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2023-03-13 00:13:04 UTC 
Created attachment 240804 [details]
Adds the editors/neovim-gtk port

It's a GTK ui for neovim
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-13 17:50:52 UTC 
Hi Alan,

WARN: Makefile: [187]: possible use of "${MKDIR} -p" found. ${MKDIR} includes "-p" by default.

I think we can remove the -p safely.

Another issue. Have you considered to use Makefile.crates as in audio/gnome-podcasts/Makefile.crates? It keeps the crate list from "polluting" the main port Makefile.
Comment 2 Alan Somers freebsd_committer freebsd_triage 2023-03-13 19:06:55 UTC 
Created attachment 240829 [details]
Responds to reviewer's comments.  Cumulative with first patch.

(In reply to Fernando Apesteguía from comment #1)
> I think we can remove the -p safely.

Oh darn, I missed that!  Fixed in the latest patch.

> Another issue. Have you considered to use Makefile.crates as in
> audio/gnome-podcasts/Makefile.crates? It keeps the crate list from "polluting"
> the main port Makefile.

No, I didn't know about that feature.  But it looks handy!  Fixed in the latest patch.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-14 11:51:09 UTC 
(In reply to Alan Somers from comment #2)
Thanks for the changes. Looks good.

Build testing...
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-14 16:32:03 UTC 
LGTM!

Build tested in 12.4{amd64,i386}, 13.1amd64, current amd64.
Run tested in 13.1amd64.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-14 16:32:36 UTC 
^Triage: reporter is committer, assign accordingly.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-03-14 17:10:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4bc4d0fcbe9aa2a278d67ad7eb4f48b7510a41e5

commit 4bc4d0fcbe9aa2a278d67ad7eb4f48b7510a41e5
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2023-03-13 00:10:37 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2023-03-14 17:08:05 +0000

    editors/neovim-gtk: new port

    It's a GTK UI for neovim

    PR:             270165
    Approved by:    fernape (ports)

 editors/Makefile                         |   1 +
 editors/neovim-gtk/Makefile (new)        |  35 ++++
 editors/neovim-gtk/Makefile.crates (new) | 159 +++++++++++++++
 editors/neovim-gtk/distinfo (new)        | 319 +++++++++++++++++++++++++++++++
 editors/neovim-gtk/pkg-descr (new)       |   4 +
 editors/neovim-gtk/pkg-plist (new)       |   7 +
 6 files changed, 525 insertions(+)