Bug 270178 - audio/cmus: Reduce default dependencies
Summary: audio/cmus: Reduce default dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-13 15:27 UTC by Daniel Engberg
Modified: 2023-03-15 08:49 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (eduardo)


Attachments
Patch for cmus (572 bytes, patch)
2023-03-13 15:27 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-13 15:27:04 UTC
Created attachment 240820 [details]
Patch for cmus

Drop default options AAC, FLAC, MP4, OPUS, VORBIS and WAV as they're handled by FFmpeg

Reference:
https://github.com/cmus/cmus/blob/v2.10.0/ip/ffmpeg.c#L530

Compile tested on FreeBSD 13.2-BETA1
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-14 08:43:38 UTC
Hello Daniel,

Thanks for patch.

I'm in doubt about what to do with depends, e.g.:

XXX_CONFIGURE_ON=       CONFIG_XXX=y
XXX_LIB_DEPENDS=        xxx.so:audio/xxx

Turning this off by default will cause that user could activate option in case of doubt.
Why not remove all that options? FFMPEG option description is informative about it support for several types: "FFmpeg support (WMA, AIFF, AC3, APE...)"
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-03-14 09:09:10 UTC
If you think that's a better solution go for it
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-03-15 08:46:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7f0d57bd050bf1ff49462a2c300e40e4afffc5ba

commit 7f0d57bd050bf1ff49462a2c300e40e4afffc5ba
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-15 08:39:37 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-03-15 08:45:11 +0000

    audio/cmus: Reduce default dependencies

    Drop default options AAC, FLAC, MP4, OPUS, VORBIS and WAV as they're
    handled by FFmpeg

    Reference:      https://github.com/cmus/cmus/blob/v2.10.0/ip/ffmpeg.c#L530
    PR:             270178

 audio/cmus/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-15 08:49:32 UTC
Committed, thanks!