Bug 270180 - audio/chromaprint: Update to latest commit
Summary: audio/chromaprint: Update to latest commit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-13 15:42 UTC by Daniel Engberg
Modified: 2023-05-01 14:59 UTC (History)
1 user (show)

See Also:
jhale: maintainer-feedback+

Attachments
Patch for chromaprint (1.37 KB, patch)
2023-03-13 15:42 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-13 15:42:13 UTC 
Created attachment 240822 [details]
Patch for chromaprint

Fixes compatibility with FFmpeg 6

Compile tested on FreeBSD 13.2-BETA1
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-03-13 15:47:15 UTC 
make test also checks out fine on 13.2-BETA1 (amd64)
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2023-03-18 14:02:06 UTC 
This fails with the current version of ffmpeg, so you can apply the patch when you're ready to do the ffmpeg update.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-03-18 14:05:30 UTC 
I suspected that would be case which is why I marked it as "Depends on" rather than "Blocks". I'll coordinate that change. Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-27 12:05:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e7e1a221158b95a1a5ae90009b0cfb429bfcdab

commit 5e7e1a221158b95a1a5ae90009b0cfb429bfcdab
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-27 10:31:34 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-27 12:01:44 +0000

    audio/chromaprint: Update to latest commit (2022-12-17)

    Fixes compatibility with FFmpeg 6

    PR:             270180
    Reviewed by:    jhale (maintainer)

 audio/chromaprint/Makefile | 8 +++++---
 audio/chromaprint/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 6 deletions(-)
Comment 5 John Hein 2023-05-01 14:42:58 UTC 
After ports b064152e2b427d4b593dbfba0f15b1ac8523a5ff (Fix DISTVERSION; DISTVERSION shouldn't go backwards), I get:

=> acoustid-chromaprint-1.5.1.20221217-aa67c95_GH0.tar.gz is not in /usr/ports/audio/chromaprint/distinfo.
=> Either /usr/ports/audio/chromaprint/distinfo is out of date, or
=> acoustid-chromaprint-1.5.1.20221217-aa67c95_GH0.tar.gz is spelled incorrectly.
*** Error code 1
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-05-01 14:59:52 UTC 
Fixed in acb87c6cb54e69462323a6a7d313c8b877606c0e, sorry about that and thanks for reporting