Created attachment 240944 [details] 0001-multimedia-plexmediaserver-plexpass-Update-to-1.31.3.patch poudriere ok runs in production on my systems (13.1 amd64)
Comment on attachment 240944 [details] 0001-multimedia-plexmediaserver-plexpass-Update-to-1.31.3.patch Looks good to me. Only suggestion I would make, hardware should be marked as amd64 on the PR. portlint: OK (0 fatal errors) Thanks for submitting!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2cd1bd4be694886a70f255f4c4446c467717878a commit 2cd1bd4be694886a70f255f4c4446c467717878a Author: Michiel van Baak Jansen <michiel@vanbaak.eu> AuthorDate: 2023-03-20 17:29:48 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-03-21 07:35:42 +0000 multimedia/plexmediaserver-plexpass: Update to 1.31.3.6819 ChangeLog: https://forums.plex.tv/t/plex-media-server/30447/565 NEW: * (MacOS) This is the last release to support MacOS 10.11-10.12 * (Windows) This is the last release to support Windows 7-8.1 FIXES: * (CreditsDetection) Improve temporary directory clean-up * (NativeSeriesScanner) Addressed an issue where certain filenames could falsely register as an episode range. * (Transcoder) Converting certain files could be unreliable when using Nvidia GPUs with certain driver versions PR: 270307 Reported by: michiel@vanbaak.eu Approved by: b.shertenlieb@yahoo.com (maintainer) multimedia/plexmediaserver-plexpass/Makefile | 13 +++++++------ multimedia/plexmediaserver-plexpass/distinfo | 6 +++--- 2 files changed, 10 insertions(+), 9 deletions(-)
Committed, Thanks!
(In reply to Fernando Apesteguía from comment #3) Thank you. :) But I do have one question. Why did the order of MASTERDIR, DISTINFOFILE, and FILESDIR needed to be changed in Makefile after all this time? The only changes to the Makefile in the patch was to change the PORTVERSION and DISTVERSIONSUFFIX.
(In reply to Ben Shertenlieb from comment #4) Hi Ben, I missed this in previous updates. Variables that are recognized (or part) of the ports framework should be presented before than the rest of the variables. In addition, we try to have them sorted alphabetically if at all possible. I should have said "committed with minor changes" or "pet linters" or something like that, sorry.
(In reply to Fernando Apesteguía from comment #5) Hi Fernando, No problems. I was just curious why. I freely admit, I'm no programmer and don't understand most of what is going on. Can't learn if you don't ask questions! I didn't write the Makefile, it was inherited when I took over the port. I have changed the order of a few things that were suggested by portlint, the port handbook, or previous committers over the last year I've been the Maintainer, but no one had ever mentioned anything about the need to reorder these variables. I will try to remember this when the next update comes up for multimedia/plexmediaserver, I'm sure that these variables are listed in the same incorrect order there as well. Ben
(In reply to Ben Shertenlieb from comment #6) No worries, the ports is in very good shape. Thank you. In addition to portlint, you can use portclippy from the portfmt package. It is also a helpful tool.