Bug 270308 - multimedia/vlc: Mark VAAPI as BROKEN
Summary: multimedia/vlc: Mark VAAPI as BROKEN
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-18 11:49 UTC by Daniel Engberg
Modified: 2024-01-14 20:18 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)

Attachments
Patch for vlc (1.56 KB, patch)
2023-03-18 11:49 UTC, Daniel Engberg 		no flags Details | Diff
Patch for vlc #2 (541 bytes, patch)
2023-03-18 18:21 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-18 11:49:19 UTC 
Created attachment 240945 [details]
Patch for vlc

Upstream don't support VAAPI on FFmpeg 5.0 or higher

Reference:
https://code.videolan.org/videolan/vlc/-/merge_requests/1245

Compile tested on FreeBSD 13.2-BETA1 (amd64)
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-03-18 14:25:58 UTC 
Comment on attachment 240945 [details]
Patch for vlc

All of this can be replaced with

  OPTIONS_EXCLUDE+=VAAPI # incompatible with ffmpeg >= 5 until vlc4

or

  OPTIONS_EXCLUDE+=VAAPI # https://code.videolan.org/videolan/vlc/-/commit/08cbeca2b732

I had a similar issue with libplacebo >= 5.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-03-18 18:21:07 UTC 
Created attachment 240952 [details]
Patch for vlc #2

Use OPT_EXCLUDE helper instead
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-27 12:05:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a49368707931fc569e5f084549df5d0ef6bd2bbf

commit a49368707931fc569e5f084549df5d0ef6bd2bbf
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-27 10:59:26 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-27 12:01:45 +0000

    multimedia/vlc: Disable VA-API

    No support VA-API on FFmpeg 5.0 or higher

    Reference:
    https://code.videolan.org/videolan/vlc/-/merge_requests/1245

    PR:             270308

 multimedia/vlc/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 4 Snake Doc 2024-01-14 16:38:11 UTC 
Is it still the case that ffmpeg 6.1 doesn't support VAAPI?  From packages, ffmpeg-6.1.1,1 has "--enable-vaapi" in the compile options.  I'm hoping VAAPI can be re-enabled in the VLC package to re-enable hardware decoding with VAAPI.
Comment 5 mario felicioni 2024-01-14 17:13:11 UTC 
There is some bug somewhere. I say this because I'm running FreeBSD 14.0 on the UFS partition and I'm using VLC + VAAPI or VDPAU enabled and everything works. But when I do it on FreeBSD 14.0 installed on the ZFS partition,VDPAU does not work.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 18:00:43 UTC 
From what I can tell most hardware acceleration in VLC is supposed to land in 4.0
Comment 7 mario felicioni 2024-01-14 19:34:16 UTC 
I'm sure that the right combination of packages installed let us work VLC with VDPAU and VAAPI. But its hard to tell which ones.
Comment 8 mario felicioni 2024-01-14 19:34:42 UTC 
anyway,someone knows when VLC 4.0 will land on FreeBSD ?
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 20:18:18 UTC 
Looking at https://code.videolan.org/videolan/vlc/-/milestones/103 I'd say "a while".

Meanwhile, to my knowledge multimedia/mpv works with hardware acceleration.