Bug 270346 - ext2fs (ext2fs/ext2_lookup.c) broken since 3c2dc524c333 (Do not panic in case of corrupted directory)
Summary: ext2fs (ext2fs/ext2_lookup.c) broken since 3c2dc524c333 (Do not panic in case...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-19 18:36 UTC by Michael Paepcke
Modified: 2023-03-21 09:29 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Paepcke 2023-03-19 18:36:17 UTC 
ext2fs (ext2fs/ext2_lookup.c) broken since 3c2dc524c333 (Do not panic in case of corrupted directory)

--- ext2_lookup.o ---
/usr/src/HEAD/sys/fs/ext2fs/ext2_lookup.c:529:16: error: variable 'mp' set but not used [-Werror,-Wunused-but-set-variable]
        struct mount *mp;
                      ^
1 error generated.

On NONE debug kernel.
SDT_PROBE4 via sdt.h include requires DTRACE (DTRACE_HOOKS,...)
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-03-20 20:08:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=bb95e6fa98a33ec3fdfed76249d5fdf863e930b0

commit bb95e6fa98a33ec3fdfed76249d5fdf863e930b0
Author:     Fedor Uporov <fsu@FreeBSD.org>
AuthorDate: 2023-03-20 20:04:38 +0000
Commit:     Fedor Uporov <fsu@FreeBSD.org>
CommitDate: 2023-03-20 20:06:57 +0000

    Fix compilation issue, when DTRACE is not defined

    PR:             270346
    Reported by:    Michael Paepcke
    MFC after:      2 week

 sys/fs/ext2fs/ext2_lookup.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Comment 2 Fedor Uporov freebsd_committer freebsd_triage 2023-03-20 20:09:23 UTC 
Should be fixed in comment above.

Thanks for report.
Comment 3 Michael Paepcke 2023-03-21 09:28:52 UTC 
Great! Thank you for the quick action!