Bug 270376 - chinese/ibus-pinyin: fix build with new sqlite3
Summary: chinese/ibus-pinyin: fix build with new sqlite3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks: 270064
  Show dependency tree / graph
 
Reported: 2023-03-20 23:03 UTC by Henry Hu
Modified: 2023-03-22 20:20 UTC (History)
1 user (show)

See Also:

Attachments
patch to fix build (2.86 KB, patch)
2023-03-20 23:03 UTC, Henry Hu 		henry.hu.sh: maintainer-approval+
Details | Diff
Poudriere build log on 13.1-RELEASE-p7 (76.07 KB, text/plain)
2023-03-20 23:04 UTC, Henry Hu 		no flags Details
Poudriere build log on 12.3-RELEASE-p9 (76.03 KB, text/plain)
2023-03-20 23:05 UTC, Henry Hu 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2023-03-20 23:03:50 UTC 
Created attachment 241024 [details]
patch to fix build

New sqlite3 broke this port; specifically, double quotes can no longer be used to enclose values inserted into rows (instead, single quotes should be used).
Created a small patch to fix this, and bumped port revision.
Also, mention that this port is deprecated, and ibus-libpinyin should be preferred.
Comment 1 Henry Hu 2023-03-20 23:04:31 UTC 
Created attachment 241025 [details]
Poudriere build log on 13.1-RELEASE-p7
Comment 2 Henry Hu 2023-03-20 23:05:01 UTC 
Created attachment 241026 [details]
Poudriere build log on 12.3-RELEASE-p9
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-03-22 20:18:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f38d0fdbea8833b50db2f8830894390c958972e8

commit f38d0fdbea8833b50db2f8830894390c958972e8
Author:     Henry Hu <henry.hu.sh@gmail.com>
AuthorDate: 2023-03-21 18:13:22 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-03-22 20:15:30 +0000

    chinese/ibus-pinyin: fix build with sqlite3 DQS option off

    Also mention that ibus-libpinyin should be preferred.

    See also:       PR 270064
    PR:             270376

 chinese/ibus-pinyin/Makefile                             |  2 +-
 .../files/patch-data_db_english_english.awk (new)        | 16 ++++++++++++++++
 .../files/{patch-init-config => patch-src_PYConfig.cc}   |  4 +---
 chinese/ibus-pinyin/pkg-descr                            |  4 ++++
 4 files changed, 22 insertions(+), 4 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-03-22 20:20:25 UTC 
Thank you for your contribution.