Bug 270397 - sysutils/conky upgrade to 1.18.3 available, solves gradient bug
Summary: sysutils/conky upgrade to 1.18.3 available, solves gradient bug
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-22 05:28 UTC by sven.a.jonsson
Modified: 2023-03-25 09:34 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sven.a.jonsson 2023-03-22 05:28:26 UTC
Lately conky has been unable to display color gradients. This appears to have been an upstream issue, since my local simple revbump 1.18.0 -> 1.18.3 solved that issue.
I think it would be appreciated by the few of us that use conky and configure it to display gradients if the port was updated.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2023-03-22 08:00:14 UTC
Hi,

Thanks for reporting.

Actually I have an update ready but I've been withholding it because this release contains a big regression in color handling, related to the change that fixed your issue.

In my testing I noticed the graph widgets (like cpugraph) are not accepting named colors anymore, but only hex colors.

for example I had to change the following:

  ${color0}${cpugraph cpu0 32,0 ${color1} ${color0}}

to

  ${color0}${cpugraph cpu0 32,0 0057B3 0D3E69}

where color0 and color1 are defined like this:

  color0 = "0D3E69",
  color1 = "0057B3"


I'd like to at least report this upstream before committing the update. It should be possible to fix this in the upstream code, but I have had little time to look at this in detail.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2023-03-22 09:01:06 UTC
To better elaborate:

My guess is the regression happened in this commit:

https://github.com/brndnmtthws/conky/commit/5e98c49c4c943b162b7a86e076f1b5479e4e640c

Here, the migration to the Colour object lost the option to use custom color variables in graphs.

I was planning to teach parse_colour() to understand ${colorX} variables. But never got around to actually doing it.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2023-03-23 08:47:28 UTC
Filed a bug report upstream, let's see what they think about this.
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2023-03-24 15:48:09 UTC
Hi,

Upstream clearified there really is no regression. I was "doing it wrong" and was confused by an unrelated change of behaviour in the program.,

I'll update the port as soon as I'm done with basic testing.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-03-25 09:32:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=84ce1196d8bd17b8db000f6d71fa3c73f2492af7

commit 84ce1196d8bd17b8db000f6d71fa3c73f2492af7
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-03-25 09:27:10 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-03-25 09:27:10 +0000

    sysutils/conky: Update to 1.18.3

    - Upstream now requires lua 3.5.x unconditionally
    - While here run portfmt(1)

    PR:             270397

 sysutils/conky/Makefile | 97 +++++++++++++++++++++++++------------------------
 sysutils/conky/distinfo |  6 +--
 2 files changed, 52 insertions(+), 51 deletions(-)
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2023-03-25 09:34:29 UTC
Update committed. Thanks!