Bug 270518 - benchmarks/fio: libnfs dependency broken and port out of date
Summary: benchmarks/fio: libnfs dependency broken and port out of date
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-29 09:04 UTC by Dani I.
Modified: 2023-04-20 11:30 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (krion)


Attachments
Fix broken libnfs build (308 bytes, patch)
2023-04-20 07:19 UTC, Dani I.
i.dani: maintainer-approval? (krion)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani I. 2023-03-29 09:04:36 UTC
I tried to build fio with LIBNFS enabled, but configure can't find the shared library even tough it was installed before. Build fails with the following error:
ERROR
ERROR: User requested feature libnfs
ERROR: That feature needs libnfs installed
ERROR: configure was not able to find it
ERROR

Additionaly fio has been updated to 3.34: https://git.kernel.dk/?p=fio.git;a=commit;h=ebd9b4dd690808f720712b9c1a1288ae0742f361
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-03-29 11:49:44 UTC
Please include information so its easy to reproduce,

Version of FreeBSD and arch
Version of ports tree (master branch or quarterly)
Using ports, poudriere, something else?

Works on my end on 13.2-RC5 (amd64) using ports (master branch, a few days old)
Comment 2 Dani I. 2023-03-29 13:35:39 UTC
(In reply to Daniel Engberg from comment #1)

Sure, sorry:
- FBSD 12.4, amd64
- Master, updated daily
- Build with poudriere
- libnfs-5.0.2 from ports:
===>   Returning to build of fio-3.33
===========================================================================
=======================<phase: lib-depends    >============================
===>   fio-3.33 depends on shared library: libnfs.so - not found
===>   Installing existing package /packages/All/libnfs-5.0.2.pkg
[fb124-master-job-01] Installing libnfs-5.0.2...
[fb124-master-job-01] Extracting libnfs-5.0.2: .......... done
===>   fio-3.33 depends on shared library: libnfs.so - found (/usr/local/lib/libnfs.so)
===>   Returning to build of fio-3.33
Comment 3 Dani I. 2023-04-18 07:08:52 UTC
Any update?
Comment 4 Dani I. 2023-04-20 07:19:19 UTC
Created attachment 241611 [details]
Fix broken libnfs build

I digged a bit more into it and found out, that fio uses pkg-config to check if libnfs is available.

root@fb124-master:/wrkdirs/usr/ports/benchmarks/fio/work/fio-3.34 # pkg-config --cflags libnfs
pkg-config: Command not found.

But due to the missing pkgconfig entry, that didn't work. After adjusting the USES param everything builds fine.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-04-20 11:30:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2513bd3092631b5c4d3db7bec8ac9f3b6543b07e

commit 2513bd3092631b5c4d3db7bec8ac9f3b6543b07e
Author:     Kirill Ponomarev <krion@FreeBSD.org>
AuthorDate: 2023-04-20 11:28:37 +0000
Commit:     Kirill Ponomarev <krion@FreeBSD.org>
CommitDate: 2023-04-20 11:28:37 +0000

    benchmarks/fio: Fix build with libnfs

    PR:             270518
    Reported by:    i.dani@outlook.com

 benchmarks/fio/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)