Created attachment 241206 [details] Makefile and distinfo patch Updated the Makefile and distinfo to use GitHub revision of binkd 1.1a-115, which is the latest formally released version. Updated Makefile with some new compile options. Updated Makefile to reflect the documentation files changes.
Can you link to release notes? Thanks Incidentally, I get 502 Bad Gateway for <http://binkd.grumbler.org/> at the time of writing.
Thanks for your submission. Some issues. Q/A: PORTREVISION should be removed Specify PORTVERSION or DISTVERSION, but not both. Please, use portlint (ports-mgmt/portlint). It is a great tool :-) Thanks!
(In reply to Graham Perrin from comment #1) Would this work as a 'rel.notes' https://github.com/pgul/binkd/blob/master/HISTORY ? Thanks!
(In reply to Fernando Apesteguía from comment #2) Sure, will do. I've raised this ticket to see whether we can do anything at all, as binkd was quite outdated for last 3 or 4 FreeBSD major releases ... I'm going to add some configure options and fix documentation/examples, then I'll re-submit the patch. Thanks!
(In reply to dz from comment #3) Yes, thanks
Created attachment 241224 [details] Fixed and linted patch Please check attached patch.
====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: etc/rc.d/binkd ===> Error: Plist issues found. *** Error code 1 Hi Andryi, Please, test patches before submission. Use poudriere or another type of clean environment.
(In reply to Fernando Apesteguía from comment #7) I've tested it with make package but missed to notice warning message, rc.d scripts was referred incorrectly - attaching fixed patch.
Created attachment 241228 [details] net/binkd patch
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bf36dd0be21aa644d56e6767129ff731371d4b39 commit bf36dd0be21aa644d56e6767129ff731371d4b39 Author: Andriy Dzedolik <dz@dolik.dev> AuthorDate: 2023-04-01 10:53:52 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-04-03 07:12:36 +0000 net/binkd: update to 1.1a-115 ChangeLog: https://github.com/pgul/binkd/blob/master/HISTORY PR: 270539 Reported by: dz@dolik.dev net/binkd/Makefile | 41 +++++++++++++++++++++++------------------ net/binkd/distinfo | 5 +++-- net/binkd/pkg-plist | 10 +++++----- 3 files changed, 31 insertions(+), 25 deletions(-)