Bug 270590 - devel/samurai: Fix the LOCALBASE is not /usr/local
Summary: devel/samurai: Fix the LOCALBASE is not /usr/local
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-01 22:26 UTC by Eric Camachat
Modified: 2023-04-05 15:51 UTC (History)
2 users (show)

See Also:

Attachments
Fix the LOCALBASE is not /usr/local (586 bytes, patch)
2023-04-01 22:26 UTC, Eric Camachat 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Camachat 2023-04-01 22:26:29 UTC 
Created attachment 241254 [details]
Fix the LOCALBASE is not /usr/local
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-05 05:43:52 UTC 
Committed,

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-04-05 05:44:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e933541b2131d644ce243630544bcf210fb4be84

commit e933541b2131d644ce243630544bcf210fb4be84
Author:     Eric Camachat <eric@camachat.org>
AuthorDate: 2023-04-03 07:27:34 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-04-05 05:38:52 +0000

    devel/samurai: Fix if LOCALBASE is not /usr/local

    PR:             270590
    Reported by:    eric@camachat.org

 devel/samurai/Makefile             |  1 +
 devel/samurai/files/patch-Makefile | 10 +++++++---
 2 files changed, 8 insertions(+), 3 deletions(-)
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-04-05 08:00:44 UTC 
This looks wrong, PREFIX != LOCALBASE.  In fact, we do pass PREFIX via MAKE_ENV, so the right fix should probably be:

-PREFIX=/usr/local
+PREFIX?=/usr/local
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-05 15:51:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5de2b4882bd8e2949664d5643b81a1660441b91

commit a5de2b4882bd8e2949664d5643b81a1660441b91
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-04-05 08:27:11 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-04-05 15:45:26 +0000

    devel/samurai: Proper fix for PREFIX variable

    PR:             270590
    Reported by:    danfe@

 devel/samurai/files/patch-Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)