Bug 270617 - mail/neomutt: Use libidn2 instead of libidn
Summary: mail/neomutt: Use libidn2 instead of libidn
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-03 08:36 UTC by Daniel Engberg
Modified: 2023-04-04 07:18 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
Patch for neomutt (689 bytes, patch)
2023-04-03 08:36 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-04-03 08:36:50 UTC 
Created attachment 241277 [details]
Patch for neomutt

Compile tested on FreeBSD 13.2-RC5
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-04-03 16:22:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b0285d61854e3af52ec6ae2eddb827a6a25f7aec

commit b0285d61854e3af52ec6ae2eddb827a6a25f7aec
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2023-04-03 16:20:32 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2023-04-03 16:21:19 +0000

    mail/neomutt: update to 20230322

    While here switch from libidn to libidn2 [1]

    PR:     270617

 mail/neomutt/Makefile  |   7 ++--
 mail/neomutt/distinfo  |   6 +--
 mail/neomutt/pkg-plist | 107 +++++++++++++++++++------------------------------
 3 files changed, 48 insertions(+), 72 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-04-04 01:54:17 UTC 
What was the reason for this change?  Anything wrong with libidn 1.x?  Neither PR not the commit log explains it.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-04-04 06:55:46 UTC 
libidn2 is the successor and supports IDNA2008, it fixes issues such as https://git.alpinelinux.org/aports/commit/?id=9585d488e292cc582849e96d3c5150743a395508

For more information see https://fedoraproject.org/wiki/Changes/IDNA2008
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-04-04 07:18:13 UTC 
(In reply to Daniel Engberg from comment #3)
> [ IDNA2008 support ]
Oh, I see, thanks.  Please include this valuable information in the commit log next time because not everyone follows IDN development as closely as you.