Bug 270674 - www/firefox: update pkg-message (remove about:networking note)
Summary: www/firefox: update pkg-message (remove about:networking note)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-06 18:40 UTC by Fernando Apesteguía
Modified: 2023-05-10 10:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gecko)
jbeich: merge-quarterly+


Attachments
Patch to update pkg-message (455 bytes, patch)
2023-04-06 18:40 UTC, Fernando Apesteguía
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-06 18:40:53 UTC
Created attachment 241328 [details]
Patch to update pkg-message

www/firefox warns about some missing features, among them:

- `about:networking` (requires link state notification)

But about:networking seems to work just fine in at least in my 13.1 amd64

Is the message outdated?
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-04-07 04:30:34 UTC
Does "Network ID" page/tab within about:networking work for you?
Comment 2 Jan Beich freebsd_committer freebsd_triage 2023-04-07 04:42:25 UTC
FreeBSD >= 13.2 has AF_NETLINK (see base 6bbfbaa6ae46), so one may want to try https://searchfox.org/mozilla-central/source/netwerk/system/netlink/NetlinkService.cpp
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-07 07:17:49 UTC
(In reply to Jan Beich from comment #1)
Ok, *that tab*. No it doesn't it shows "Unknown" for the three fields.

Not a big deal, buy maybe an update saying that "Network ID" page does not work instead of the whole tab would be less confusing :-)
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-12 16:10:29 UTC
While the message might be improved, I don't want to push it any further.

Thanks for the clarification.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-05-10 10:38:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=01998e811d41fe6856ade20e4be3841de29c9889

commit 01998e811d41fe6856ade20e4be3841de29c9889
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-10 10:37:18 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-10 10:37:20 +0000

    www/firefox: clarify about:networking non-support

    PR:             270674

 www/firefox-esr/pkg-message | 2 +-
 www/firefox/pkg-message     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-05-10 10:39:07 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a943174d3fdb6f465a03c55cdff0d80c94abaf09

commit a943174d3fdb6f465a03c55cdff0d80c94abaf09
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-10 10:37:18 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-10 10:38:15 +0000

    www/firefox: clarify about:networking non-support

    PR:             270674
    (cherry picked from commit 01998e811d41fe6856ade20e4be3841de29c9889)

 www/firefox-esr/pkg-message | 2 +-
 www/firefox/pkg-message     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)