Bug 270921 - security/tailscale: introduce tailscaled_state_dir rc conf setting
Summary: security/tailscale: introduce tailscaled_state_dir rc conf setting
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-18 20:55 UTC by R. Christian McDonald
Modified: 2023-04-27 08:31 UTC (History)
1 user (show)

See Also:
ashish: maintainer-feedback+


Attachments
security/tailscale: introduce tailscaled_state_dir rc conf setting (2.05 KB, patch)
2023-04-18 20:55 UTC, R. Christian McDonald
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R. Christian McDonald 2023-04-18 20:55:50 UTC
Created attachment 241571 [details]
security/tailscale: introduce tailscaled_state_dir rc conf setting

This patch introduced a new rc conf setting `tailscaled_state_dir`. This is useful for changing where tailscaled stores persistent state information. In certain situations, users might not want this stored at `/var/db/tailscale`. This knob allows them to override that default.
Comment 1 R. Christian McDonald 2023-04-18 20:56:35 UTC
It is also worth mentioning that tailscaled doesn't understand CACHE_DIRECTORY environment variable. This patch is the correct way of setting the state directory
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-04-27 08:22:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c4c48ecd652d631f7521ea797292cb2b26709d5

commit 8c4c48ecd652d631f7521ea797292cb2b26709d5
Author:     Christian McDonald <rcm@rcm.sh>
AuthorDate: 2023-04-18 20:51:41 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2023-04-27 08:20:33 +0000

    security/tailscale: introduce tailscaled_state_dir rc knob

    PR:             270921
    MFH:            2023Q2

 security/tailscale/Makefile            | 2 +-
 security/tailscale/files/tailscaled.in | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-27 08:27:28 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=467256a89512b0682b8b9367de61c08419adab84

commit 467256a89512b0682b8b9367de61c08419adab84
Author:     Christian McDonald <rcm@rcm.sh>
AuthorDate: 2023-04-18 20:51:41 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2023-04-27 08:26:09 +0000

    security/tailscale: introduce tailscaled_state_dir rc knob

    PR:             270921
    MFH:            2023Q2
    (cherry picked from commit 8c4c48ecd652d631f7521ea797292cb2b26709d5)

 security/tailscale/Makefile            | 2 +-
 security/tailscale/files/tailscaled.in | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2023-04-27 08:31:29 UTC
Committed, thanks!