Created attachment 241588 [details] Several new ports at once I could split the patch on the per-port basis, please let me know if it's needed. Thank you.
That's quite a big patch. It might be easier to review if you published it as a DR on https://reviews.freebsd.org
Comment on attachment 241588 [details] Several new ports at once Also don't forget to set the maintainer-approved flag on new ports!
(In reply to Robert Clausecker from comment #2) Got it, thanks!
(In reply to Robert Clausecker from comment #1) Sorry for a delay, I've just created a review request here: https://reviews.freebsd.org/D39868 Thank you.
wen@ has unfortunately already committed a port of www/angie without checking for open bug reports. However, your port is much more comprehensive. I'll leave this one open so perhaps wen's port can be improved by / replaced with your patch.
Comment on attachment 241588 [details] Several new ports at once Now subject to maintainer approval from wen@ (www/angie maintainer).
I am sorry added angie to portstree without checking bug resport, feel free reset maintainer to submitter and go ahead ! wen
I'm absolutely ok with both approaches :) Probably, it will be a bit easier for me to keep angie ecosystem up to date since I'm deeply involved in angie development and one of my duties is maintenance of packaging for supported platforms (https://angie.software/en/install/) @fuz, please let me know your decision and I'm ready to update this PR with the latest patch. Also, I already have ready ports for other 10+ dynamic modules. I'm not sure if it makes sense to send them immediately or later, separately.
Will commit D39868 with my next batch. Please submit the remaining modules as a new PR. A set of patch files (git-format-patch) should suffice, ideally one patch for each new module.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=38e8d9ecc4fba0264bfc094f6d8984135ac02940 commit 38e8d9ecc4fba0264bfc094f6d8984135ac02940 Author: Oleg A. Mamontov <oleg@mamontov.net> AuthorDate: 2023-08-05 12:25:34 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-08-06 12:42:48 +0000 www/angie: replace with more comprehensive port Replace port with a version that supports modules as slave ports. PR: 270933 Approved by: wen Differential Revision: https://reviews.freebsd.org/D39868 www/angie/Makefile | 194 ++++++++++++++++++++++++--- www/angie/distinfo | 4 +- www/angie/files/angie.conf.sample.in (new) | 41 ++++++ www/angie/files/angie.in (new) | 73 ++++++++++ www/angie/files/default.conf.sample.in (new) | 49 +++++++ www/angie/files/example.conf.sample.in (new) | 24 ++++ www/angie/files/pkg-message.in (new) | 13 ++ www/angie/pkg-descr | 8 +- www/angie/pkg-plist | 47 ++++--- 9 files changed, 411 insertions(+), 42 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=18b138ae812cdfae0c4195c87554a984de288ae5 commit 18b138ae812cdfae0c4195c87554a984de288ae5 Author: Oleg A. Mamontov <oleg@mamontov.net> AuthorDate: 2023-08-05 12:26:39 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-08-06 12:42:48 +0000 www/angie-module-geoip2: Angie GeoIP2 dynamic module Module captures information from the client IP address in variables, using the MaxMind GeoIP2 databases. PR: 270933 Differential Revision: https://reviews.freebsd.org/D39868 www/Makefile | 1 + www/angie-module-geoip2/Makefile (new) | 26 ++++++++++++++++++++++ www/angie-module-geoip2/files/pkg-message.in (new) | 16 +++++++++++++ www/angie-module-geoip2/pkg-descr (new) | 2 ++ www/angie-module-geoip2/pkg-plist (new) | 5 +++++ 5 files changed, 50 insertions(+)
Thank you for your contribution. I'm sorry it took so longer. Please submit the remaining modules in new bug reports.