Bug 271046 - devel/git-extras: Update to 7.0.0
Summary: devel/git-extras: Update to 7.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://github.com/tj/git-extras/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-24 17:43 UTC by Igor Ostapenko
Modified: 2023-04-28 16:21 UTC (History)
1 user (show)

See Also:

Attachments
git-extras-7.0.0.diff (2.68 KB, patch)
2023-04-24 17:43 UTC, Igor Ostapenko 		igor.ostapenko: maintainer-approval+
Details | Diff
git-extras-7.0.0.diff (3.08 KB, patch)
2023-04-25 12:33 UTC, Igor Ostapenko 		igor.ostapenko: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Ostapenko 2023-04-24 17:43:22 UTC 
Created attachment 241704 [details]
git-extras-7.0.0.diff
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-04-24 22:59:43 UTC 
Please check the location where bash completion files are installed.  As per § 6.31 Porter's Handbook, these go to

    ${PREFIX}/etc/bash_completion.d

for bash, but you currently install them into

    ${PREFIX}/share/bash-completion/completions/git-extras

Please adjust the installation path in accordance to our conventions.
Comment 2 Igor Ostapenko 2023-04-25 12:33:29 UTC 
Created attachment 241738 [details]
git-extras-7.0.0.diff
Comment 3 Igor Ostapenko 2023-04-25 12:37:32 UTC 
Thanks for spotting. Please, find the revised patch.

I will make an attempt to push these changes to the git-extras project itself, probably we will be able to avoid patching at all.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-28 16:19:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9136596bb35b59fb654b31b6748ed97c00e6aadc

commit 9136596bb35b59fb654b31b6748ed97c00e6aadc
Author:     Igor Ostapenko <igor.ostapenko@pm.me>
AuthorDate: 2023-04-25 20:38:11 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-04-28 16:13:39 +0000

    devel/git-extras: update to 7.0.0

    Changelog: https://github.com/tj/git-extras/releases/tag/7.0.0

    PR:             271046

 devel/git-extras/Makefile             |  2 +-
 devel/git-extras/distinfo             |  6 +++---
 devel/git-extras/files/patch-Makefile | 30 ++++++++----------------------
 devel/git-extras/pkg-plist            |  2 +-
 4 files changed, 13 insertions(+), 27 deletions(-)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-04-28 16:21:27 UTC 
Thank you for your contribution.