Bug 271089 - x11/waybar: hyprland flavor for sndio
Summary: x11/waybar: hyprland flavor for sndio
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on: 264678
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-27 02:45 UTC by slowdive
Modified: 2023-04-29 09:05 UTC (History)
1 user (show)

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description slowdive 2023-04-27 02:45:42 UTC
Current `waybar-hyprland` is built with pulseaudio. Should it there be flavors for sndio/etc as well? Or maybe just mirror nopulse for hypr? I was thinking to submit a flavor but not sure about the approach.be
Comment 1 slowdive 2023-04-27 02:49:49 UTC
/it*.be | my bad, didn't noticed I pasted in the middle of the string
Comment 2 slowdive 2023-04-27 02:52:26 UTC
That would follow the issue submitted last years as well
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-28 20:14:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d8e7e2cdb2b9a7ef277a3baebdedaac084b30359

commit d8e7e2cdb2b9a7ef277a3baebdedaac084b30359
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-04-28 20:03:23 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-04-28 20:13:55 +0000

    x11/waybar: add hyprland_nopulse flavor

    PR:             271089

 x11/waybar/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-28 20:14:47 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5123e648f417db2ef53663b1ebacfb8a14cabe68

commit 5123e648f417db2ef53663b1ebacfb8a14cabe68
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-04-28 20:03:23 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-04-28 20:14:11 +0000

    x11/waybar: add hyprland_nopulse flavor

    PR:             271089
    (cherry picked from commit d8e7e2cdb2b9a7ef277a3baebdedaac084b30359)

 x11/waybar/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 5 Jan Beich freebsd_committer freebsd_triage 2023-04-28 20:18:31 UTC
SNDIO is already enabled by default. If you're concerned about such a small dependency build from ports instead of using packages. Providing flavors for each option leads to a combinatorial explosion.
Comment 6 slowdive 2023-04-28 23:36:13 UTC
True. I thought waybar's PA/SNDIO case is an exception due PA's poor performance. A lot of posts on the forum also suggests switching defaults from PA so I was just trying to improve coverage since I do not deploy waybar for myself.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2023-04-29 01:31:47 UTC
(In reply to slowdive from comment #6)
> I thought waybar's PA/SNDIO case is an exception due PA's poor performance.

- Waybar still doesn't have OSS support, native to FreeBSD
- Waybar >= 0.9.14 supports Jack, not just PulseAudio and sndio

> A lot of posts on the forum also suggests switching defaults from PA

Related to Waybar or in general? FreeBSD Forums have a lot of anti-PulseAudio and anti-Wayland bias.

> I was just trying to improve coverage since I do not deploy waybar for myself.

Only Waybar users know which flavors are useful. I've added -hyprland flavor per user request in https://github.com/hyprwm/hyprland-wiki/issues/127

Now this makes me wonder if -nopulse is pointless given you're not a user while Waybar is already bloated. Many ports with PULSEAUDIO by default don't bother to have -nopulse (or similar) flavor.
Comment 8 slowdive 2023-04-29 09:05:11 UTC
(In reply to Jan Beich from comment #7)

Related to PA in general.

> Now this makes me wonder if -nopulse is pointless given you're not a user while Waybar is already bloated.

If I am the only one holding both -nopulse flavors then it is a very trivial dilemma since I do not care about my personal needs.