Bug 271263 - x11/kitty: Upgrade to v0.28.1
Summary: x11/kitty: Upgrade to v0.28.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nicola Vitale
URL: https://github.com/kovidgoyal/kitty/r...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2023-05-05 16:32 UTC by Yonas Yanfa
Modified: 2023-05-19 08:50 UTC (History)
4 users (show)

See Also:


Attachments
git format-patch (6.25 KB, patch)
2023-05-07 14:21 UTC, Vidar Karlsen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yonas Yanfa 2023-05-05 16:32:43 UTC
The latest version is 0.28.1
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-05-06 13:59:28 UTC
Thank you for your bug report.  Can you provide a patch?  If yes, are you interested in taking over maintainership over this port?
Comment 2 Yonas Yanfa 2023-05-06 21:30:00 UTC
(In reply to Robert Clausecker from comment #1)

Can you provide a patch?

Unfortunately, I cannot.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-05-06 21:36:24 UTC
Thanks.
Comment 4 Vidar Karlsen 2023-05-07 14:21:39 UTC
Created attachment 242036 [details]
git format-patch

IMPORTANT: Neither this nor the previous version will currently build in
poudriere without the change discussed in Phab D39306 [1] and Bug #270511 [2].
Therefore, it should not be committed until D39306 has been completed
and committed, as doing so will lead to deletion of a functioning 0.28.0
pkg and a failed build of 0.28.1.

[1] https://reviews.freebsd.org/D39306
[2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270511

QA (with the above-mentioned change to Mk/Uses/python):
- poudriere testport 12.4-i386:  ok
- poudriere testport 12.4-amd64: ok
- poudriere testport 13.2-amd64: ok
- ports make install 13.2-amd64: ok

Changelog (upstream): https://sw.kovidgoyal.net/kitty/changelog/
- Fix a regression in the previous release that broke the remote file
  kitten (#6186)
- Fix a regression in the previous release that broke handling of some
  keyboard shortcuts in some kittens on some keyboard layouts (#6189)
- Fix a regression in the previous release that broke usage of custom
  themes (#6191)

Changelog (port):
- Cleaned up the Makefile order to make portclippy happy
- diff_speedup.so and unicode_names.so removed from _STRIP_TARGETS
  and pkg-plist as they are no longer being build (from upstream)


If someone wants to maintain this port, feel absolutely free to substitute
your address for mine.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-05-07 20:22:56 UTC
Thank you for your patch.  Added dependent PR.
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-05-15 09:19:38 UTC
Assign to new maintainer.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-05-17 10:02:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=88288baf63e0e30a63d83f7b857c66719f901852

commit 88288baf63e0e30a63d83f7b857c66719f901852
Author:     Vidar Karlsen <vidar@karlsen.tech>
AuthorDate: 2023-05-17 09:56:38 +0000
Commit:     Nicola Vitale <nivit@FreeBSD.org>
CommitDate: 2023-05-17 10:01:42 +0000

    x11/kitty: Update to 0.28.1

    - cleaned up the Makefile order to make portclippy and portfmt happy
    - diff_speedup.so and unicode_names.so removed from _STRIP_TARGETS
      and pkg-plist as they are no longer being build (from upstream)

    Release changes: https://sw.kovidgoyal.net/kitty/changelog/#id1

    PR:             271263
    Reported by:    Yonas Yanfa <yonas.yanfa@gmail.com>

 x11/kitty/Makefile | 40 +++++++++++++++++++---------------------
 x11/kitty/distinfo | 10 +++++-----
 2 files changed, 24 insertions(+), 26 deletions(-)
Comment 8 Tomoaki AOKI 2023-05-17 17:27:44 UTC
pkg-plist part of the patch seems to be missed when committed, thus fails to package.

===>  Building package for kitty-0.28.1
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/kitty/work/stage/usr/local/lib/kitty/kittens/diff/diff_speedup.so:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/x11/kitty/work/stage/usr/local/lib/kitty/kittens/unicode_input/unicode_names.so:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/x11/kitty
Comment 9 fgorter 2023-05-17 18:22:23 UTC
(In reply to Tomoaki AOKI from comment #8)

The 2 problematic files remain listed in pkg-plist

removing these 2 lines from the pkg-plist file:

lib/kitty/kittens/diff/diff_speedup.so
lib/kitty/kittens/unicode_input/unicode_names.so


Solves the problem & results in a successful make install.
Comment 10 Tomoaki AOKI 2023-05-17 20:56:49 UTC
(In reply to fgorter from comment #9)

Yes.
But the removal of 2 lines are included in the original patch here.
So the commit was incomplete.
Comment 11 Nicola Vitale freebsd_committer freebsd_triage 2023-05-18 08:24:01 UTC
I forgot to copy that file from poudriere dir, sorry. Fixed:

https://cgit.freebsd.org/ports/commit/?id=2da1e786ebf00375a30ce1e721622556037cf776

Thanks, for the note.
Comment 12 Tomoaki AOKI 2023-05-18 23:39:47 UTC
(In reply to Nicola Vitale from comment #11)

Confirmed. Thanks!
Comment 13 Nicola Vitale freebsd_committer freebsd_triage 2023-05-19 08:50:00 UTC
Thank you all for the feedback!