Bug 271266 - if_wg.h being installed twice
Summary: if_wg.h being installed twice
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL: https://reviews.freebsd.org/D40031
Keywords:
Depends on:
Blocks: 244596
  Show dependency tree / graph
 
Reported: 2023-05-05 19:00 UTC by Ed Maste
Modified: 2023-05-10 01:12 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2023-05-05 19:00:37 UTC 
Any given file in a FreeBSD installworld should be installed exactly once. From a recent Cirrus-CI run on main:

error: ./usr/include/dev/wg/if_wg.h file repeated with same meta: line 13367,14164

https://cirrus-ci.com/task/6262656709951488?logs=package_check#L4

It appears there are four such files at present - if_wg.h, and three loader help files (PR271178).
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-05-10 01:11:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b6271cc0d0cd6e4f9592ac88b3892c3931e5f25d

commit b6271cc0d0cd6e4f9592ac88b3892c3931e5f25d
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-05-10 00:28:44 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-05-10 01:09:39 +0000

    includes: avoid installing if_wg.h twice

    if_wg.h was installed via dev/wg in LSUBDIRS and also explicitly.  We
    want to install only wg/if_wg.h not the other headers, so add dev/wg to
    the skip list in the copies and symlinks targets.

    PR:             271266
    Reviewed by:    kevans
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D40031

 include/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)