Bug 271280 - games/veloren-weekly: update to s20230506
Summary: games/veloren-weekly: update to s20230506
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL: https://gitlab.com/veloren/veloren/-/...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-06 15:18 UTC by (intentionally left blank)
Modified: 2023-05-06 23:21 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly+


Attachments
v0 (26.09 KB, patch)
2023-05-06 15:18 UTC, (intentionally left blank)
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description (intentionally left blank) 2023-05-06 15:18:52 UTC
Created attachment 242018 [details]
v0

server.veloren.net rolled out a new update again, now with:
https://gitlab.com/veloren/veloren/-/commit/6367a51fa3dd
so be warned if you farm T5 bosses the fun way.

Disclaimer:

* I could mess up crates and overlook something else,
  this is the minimum to join server.veloren.net,
  so claim credit yourself once meets your QA standard.

* I tested only on -main, rustc here does not come from ports.

* I build without lto and with codegen-units >1 to not waste time.
Comment 1 (intentionally left blank) 2023-05-06 15:19:43 UTC
Also, why mirror distfile on cluster? Fetches fine here.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-05-06 23:10:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7f0fbef9ffb070884c06780cf0d378ee0d48f675

commit 7f0fbef9ffb070884c06780cf0d378ee0d48f675
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-06 05:12:20 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-06 23:08:37 +0000

    games/veloren-weekly: update to s20230506

    Changes:        https://gitlab.com/veloren/veloren/-/compare/59f12ef11...95a38ff8f
    PR:             271280

 games/veloren-weekly/Makefile        |  4 +-
 games/veloren-weekly/Makefile.crates | 38 +++++++++++------
 games/veloren-weekly/distinfo        | 82 ++++++++++++++++++++++++------------
 3 files changed, 83 insertions(+), 41 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-06 23:10:19 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c2396bef8489441a3fb65e20da1bc4a3041fef8d

commit c2396bef8489441a3fb65e20da1bc4a3041fef8d
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-06 05:12:20 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-06 23:09:49 +0000

    games/veloren-weekly: update to s20230506

    Changes:        https://gitlab.com/veloren/veloren/-/compare/59f12ef11...95a38ff8f
    PR:             271280
    (cherry picked from commit 7f0fbef9ffb070884c06780cf0d378ee0d48f675)

 games/veloren-weekly/Makefile        |  4 +-
 games/veloren-weekly/Makefile.crates | 38 +++++++++++------
 games/veloren-weekly/distinfo        | 82 ++++++++++++++++++++++++------------
 3 files changed, 83 insertions(+), 41 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-05-06 23:14:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d103565dc0b0dd9538cd3c18881762107ace3c19

commit d103565dc0b0dd9538cd3c18881762107ace3c19
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-06 23:12:31 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-06 23:14:11 +0000

    games/veloren-weekly: drop distfile mirror

    This reverts commit 12e296fafe63c66f916e51e63b5fbfc801572c1d.

    PR:             271280

 games/veloren-weekly/Makefile | 3 ---
 1 file changed, 3 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-05-06 23:15:21 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2833268a2d6f1831b5665b1d5f4d42f04142f67e

commit 2833268a2d6f1831b5665b1d5f4d42f04142f67e
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-06 23:12:31 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-06 23:14:33 +0000

    games/veloren-weekly: drop distfile mirror

    This reverts commit 12e296fafe63c66f916e51e63b5fbfc801572c1d.

    PR:             271280
    (cherry picked from commit d103565dc0b0dd9538cd3c18881762107ace3c19)

 games/veloren-weekly/Makefile | 3 ---
 1 file changed, 3 deletions(-)
Comment 6 Jan Beich freebsd_committer freebsd_triage 2023-05-06 23:21:03 UTC
Thanks for reporting. I did my fix independently. Besides, TIMESTAMP needs to match Git commit date which, thanks to git-archive(1), is also the "modification time" of any unpatched file from the same distfile.

Not much time to play with this version until the next Thursday update, especially if /latest misses Sunday's package rebuild.

(In reply to throwaway_vthgwq4 from comment #1)
> Also, why mirror distfile on cluster? Fetches fine here.

LFS (used by assets) can be fragile: fetch timeout or different contents/checksum. Let's see what happens.