Created attachment 242103 [details] patch to upgrade games/chessx port to the version 1.6.0 Hello, the attached patch upgrades chessx to 1.6.0 (current version in FreeBSD is 1.5.7, and it is a beta version). Since the port does not have a maintainer, and I am - actively using FreeBSD, - actively using chessx, - have a lot of time, I would like to volunteer to become a maintainer of this port. -- Alexey
Thank you for your submission and your wish to maintain this port. This is very appreciated! Please check the following issues: - please use DISTVERSION over PORTVERSION if possible - please clear PORTREVISION when updating a port to a new version Rest of the patch looks good!
Will do. I will also add installation of the application icon, which I removed due to the strange problems.
Created attachment 242105 [details] New version of the patch, updating chessx to 1.6.0
Will commit with small changes.
Is there a changelog for this update?
Indeed, there is a changelog. How do I add it to port?
Created attachment 242106 [details] ChessX changelog, as of version 1.6.0.
Add a link to the bug report. I'll go and add it to the commit message.
I do not know how to do that. Changelog is a part of tarball, which is hosted on sourceforge. I'll try to find it in a linkable state.
If it's not available online, that's okay. For this update, I'll just link to the changelog in attachment #242106 [details]. For future updates, we'll have to find a solution.
Maybe this -- https://github.com/Isarhamster/chessx/blob/master/ChangeLog.md -- but I am not sure it is "official".
It is official. The source code link at ChessX website points to this GitHub repository.
A test build failed with plist issues: ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: share/metainfo/io.sourceforge.ChessX.metainfo.xml Error: Orphaned: @dir share/icons/hicolor ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Please check and resubmit.
Created attachment 242119 [details] Yet another version of the patch Also added a link to the version 1.6.0 changelog to the commit message.
Is it better now?
Looks good. Will commit with some small changes.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d40f8cab97ebcb5687ddf5a7744581a999bbd23d commit d40f8cab97ebcb5687ddf5a7744581a999bbd23d Author: Alexey Vyskubov <alexey@pentode.fi> AuthorDate: 2023-05-10 11:27:45 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-11 23:23:30 +0000 games/chessx: Update to 1.6.0. * Volunteer to be a maintainer * Do not include obsolete i18n: see https://sourceforge.net/p/chessx/wiki/HOWTO%20Translate/ * Point to the proper license file * Fix bug preventing compilation if USE_SPEECH is not defined Changelog: https://github.com/Isarhamster/chessx/blob/master/ChangeLog.md#may-2023-version-160 PR: 271348 games/chessx/Makefile | 21 ++++-- games/chessx/distinfo | 6 +- games/chessx/files/patch-chessx.pro | 80 ++++++++++------------ .../files/patch-src_gui_chessxsettings.cpp (new) | 16 +++++ .../files/patch-src_gui_chessxsettings.h (new) | 19 +++++ 5 files changed, 90 insertions(+), 52 deletions(-)
Had to apply a little FreeBSD 12 hotfix to make it work. Thank you for your contribution!