Bug 271472 - graphics/gdk-pixbuf2: Fails to build with TIFF option disabled
Summary: graphics/gdk-pixbuf2: Fails to build with TIFF option disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-17 16:27 UTC by Tassilo Philipp
Modified: 2023-05-19 19:43 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tassilo Philipp 2023-05-17 16:27:41 UTC 
The build fails (in the configure phase), with the following error when the TIFF option is disabled:

-------
[...]
Checking for function "jpeg_simple_progression" with dependency libjpeg: YES
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency libtiff-4 found: NO (tried pkgconfig)

meson.build:330:13: ERROR: Dependency "libtiff-4" not found, tried pkgconfig
--------
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2023-05-17 23:12:39 UTC 
Moin moin 

From a frist glance it looks like the option helpers in the Makefile are wrong. 

it should be 
FOO_MESON_ENABLED=bar
note the ENABLED instead of ENABLE

mfg Tobias
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2023-05-19 06:13:46 UTC 
(In reply to Tassilo Philipp from comment #0)
Moin moin 

I pushed the change to the option code -- could you please check whether that fixes the issue for you?

mfg Tobias
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-19 06:13:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=77005af64c4a0166929192f6b7c461ae54f374ff

commit 77005af64c4a0166929192f6b7c461ae54f374ff
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2023-05-19 06:11:44 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2023-05-19 06:13:18 +0000

    graphics/gdk-pixbuf2: fix option variables

    The Makefile was using
            FOO_MESON_ENABLE=       bar
    instead of
            FOO_MESON_ENABLED=      bar
    so those values were never passed to meson in the first place.

    PR:             271472

 graphics/gdk-pixbuf2/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 4 Tassilo Philipp 2023-05-19 07:14:34 UTC 
Tested and it's working! Thanks, that was quick!
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2023-05-19 07:30:02 UTC 
(In reply to Tassilo Philipp from comment #4)
Awesome :)
Comment 6 Jan Beich freebsd_committer freebsd_triage 2023-05-19 19:43:33 UTC 
FWIW, such issues can be found via portscan from ports-mgmt/portfmt e.g.,

$ git checkout 77005af64c4a~1
$ portscan -p . graphics/gdk-pixbuf2
[100%] finished in 0s
V       graphics/gdk-pixbuf2                     JPEG_MESON_ENABLE
V       graphics/gdk-pixbuf2                     PNG_MESON_ENABLE
V       graphics/gdk-pixbuf2                     TIFF_MESON_ENABLE