Bug 271516 - [NEW PORT] x11-fonts/intel-one-mono Intel One Mono Font Family
Summary: [NEW PORT] x11-fonts/intel-one-mono Intel One Mono Font Family
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lewis Cook
URL: https://github.com/intel/intel-one-mono
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-19 16:25 UTC by Andriy Dzedolik
Modified: 2023-05-23 09:34 UTC (History)
2 users (show)

See Also:


Attachments
x11-fonts/intel-one-mono patch (3.55 KB, application/mbox)
2023-05-19 16:25 UTC, Andriy Dzedolik
no flags Details
patch.diff (2.80 KB, patch)
2023-05-23 04:31 UTC, Lewis Cook
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Dzedolik 2023-05-19 16:25:22 UTC
Created attachment 242283 [details]
x11-fonts/intel-one-mono patch

Intel One Mono is an expressive monospaced font family that’s built with clarity, legibility, and the needs of developers in mind.

It’s easier to read, and available for free, with an open-source font license.

Identifying the typographically underserved low-vision developer audience, Frere-Jones Type designed the Intel One Mono typeface in partnership with the Intel Brand Team and VMLY&R, for maximum legibility to address developers' fatigue and eyestrain and reduce coding errors. A panel of low-vision and legally blind developers provided feedback at each stage of design.

Intel One Mono also covers a wide range of over 200 languages using the Latin script. The Intel One Mono fonts are provided in four weights — Light, Regular, Medium, and Bold — with matching italics, and we are happy to share both an official release of fonts ready to use as well as editable sources.
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2023-05-23 04:31:59 UTC
Created attachment 242341 [details]
patch.diff

Hi, thank you for the submission!

See included patch with some improvements made, most notably;

* Removed GH_PROJECT, this is inherited from PORTNAME.
* Removed GH_TAGNAME, we can set this accordingly by adding DISTVERSIONPREFIX,
  resulting in V1.2.0 (aka DISTVERSIONFULL).
* Install both TTF and OTF variations for best compatibility, reflect this in
  the COMMENT (rather than explicitly stating truetype, which was installing OTF
  anyway).
* Pet with both portlint, portclippy and portfmt to ensure correctness (variable ordering,
  formatting, etc) [0].

[0] https://docs.freebsd.org/en/books/porters-handbook/testing/#testing-portclippy

If you have any questions, please do not hesitate asking. Are you happy me with committing your port with the included changes?

Cheers!

^Lewis
Comment 2 Andriy Dzedolik 2023-05-23 08:29:19 UTC
Hi, 
thanks for your inputs and patch updates - looks great.
Appreciate your help and explanations.
Andriy
Comment 3 Andriy Dzedolik 2023-05-23 08:29:57 UTC
Hi, 
thanks for your inputs and patch updates - looks great.
Appreciate your help and explanations.
Andriy
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-05-23 09:33:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=84b834ca7fa101c24901203f372f35ed515784ac

commit 84b834ca7fa101c24901203f372f35ed515784ac
Author:     Andriy Dzedolik <dz@dolik.dev>
AuthorDate: 2023-05-23 09:27:58 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2023-05-23 09:32:18 +0000

    x11-fonts/intel-one-mono: Intel One Mono font

    Intel One Mono is an expressive monospaced font family that's built with
    clarity, legibility, and the needs of developers in mind.

    PR:     271516

 x11-fonts/Makefile                       |  1 +
 x11-fonts/intel-one-mono/Makefile (new)  | 26 ++++++++++++++++++++++++++
 x11-fonts/intel-one-mono/distinfo (new)  |  3 +++
 x11-fonts/intel-one-mono/pkg-descr (new) |  8 ++++++++
 x11-fonts/intel-one-mono/pkg-plist (new) | 16 ++++++++++++++++
 5 files changed, 54 insertions(+)
Comment 5 Lewis Cook freebsd_committer freebsd_triage 2023-05-23 09:34:53 UTC
Committed! :]