Bug 271720 - deskutils/xfce4-generic-slider: update to 1.0.0
Summary: deskutils/xfce4-generic-slider: update to 1.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-30 07:20 UTC by Guido Falsi
Modified: 2023-05-30 14:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
patch v1 (4.52 KB, patch)
2023-05-30 07:20 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2023-05-30 07:20:54 UTC 
Created attachment 242492 [details]
patch v1

Hi,

XFCE has released version 1.0.00 of the generic slider plugin, making it available as an official plugin.

I have updated the port accordingly, making it similar to the other plugins now that it is properly distributed with precompiled configure script and translations.

Can you approve this update?

I'd also like to ask you if you'd consider moving maintainership to xfce@ like other plugins. You can maintain implicit commit rights to this port.

Thanks in advance!
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2023-05-30 08:49:27 UTC 
Hi Guido,

I approve the changes including the maintainer transfer. This port has come a long way. I am glad it's regained some upstream TLC.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2023-05-30 13:49:50 UTC 
Thanks! Committing the update with changed maintainer shortly.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-30 14:49:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=45012244df59a8c67fb8f8ee2fcabe37066e2192

commit 45012244df59a8c67fb8f8ee2fcabe37066e2192
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-05-30 14:47:11 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-05-30 14:47:11 +0000

    deskutils/xfce4-generic-slider: Update to 1.0.0

    - Download from xfce officail mirrors
    - Remove old :gtk3 option to xfce USES
    - Use bundled configure (xfce4-dev-tools not required anymore)
    - Also package icons and translations, adding NLS options.
    - Pass maintainership to xfce@

    PR:             271720
    Approved by:    ehaupt (former maintainer)

 deskutils/xfce4-generic-slider/Makefile        | 28 ++++++++++-----------
 deskutils/xfce4-generic-slider/distinfo        |  6 ++---
 deskutils/xfce4-generic-slider/pkg-plist (new) | 34 ++++++++++++++++++++++++++
 3 files changed, 50 insertions(+), 18 deletions(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2023-05-30 14:50:47 UTC 
Committed, thanks!