Bug 271737 - Purism coreboot keyboard non-functional due to quirks mode
Summary: Purism coreboot keyboard non-functional due to quirks mode
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.2-STABLE
Hardware: amd64 Any
: --- Affects Some People
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-30 21:32 UTC by Jon H
Modified: 2024-12-28 18:02 UTC (History)
0 users

See Also:
linimon: mfc-stable13?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon H 2023-05-30 21:32:54 UTC 
On Purism coreboot systems the quirks mode in atkbdc prevents built in Keyboard from being used. Following patch fixes problem. 


diff --git a/sys/dev/atkbdc/atkbdc.c b/sys/dev/atkbdc/atkbdc.c
index c3c53f98e491..f24c3d883351 100644
--- a/sys/dev/atkbdc/atkbdc.c
+++ b/sys/dev/atkbdc/atkbdc.c
@@ -114,6 +114,7 @@ struct atkbdc_quirks {
 
 static struct atkbdc_quirks quirks[] = {
     {"coreboot", "System76", NULL, 0},
+    {"coreboot", "Purism", NULL, 0},
     {"coreboot", NULL, NULL,
        KBDC_QUIRK_KEEP_ACTIVATED | KBDC_QUIRK_IGNORE_PROBE_RESULT |
        KBDC_QUIRK_RESET_AFTER_PROBE | KBDC_QUIRK_SETLEDS_ON_INIT},
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-06-28 17:20:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=599a4548f8f1758afe1d33c53e9a56e42c5f3e30

commit 599a4548f8f1758afe1d33c53e9a56e42c5f3e30
Author:     Jon Hopper <jon@thesoo.org>
AuthorDate: 2023-06-28 17:04:46 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-06-28 17:19:24 +0000

    Adds support for Purism coreboot keyboards

    On Purism coreboot systems the quirks mode in atkbdc prevents built in
    Keyboard from being used. Add quirk to prevent that.

    MFC After:              2 weeks
    PR:                     271737
    Reviewed by:            imp
    Differential Revision:  https://reviews.freebsd.org/D40405

 sys/dev/atkbdc/atkbdc.c | 1 +
 1 file changed, 1 insertion(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-28 18:02:24 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=dfdcb418d7b8891843130c9415f9778b227945d8

commit dfdcb418d7b8891843130c9415f9778b227945d8
Author:     Jon Hopper <jon@thesoo.org>
AuthorDate: 2024-12-28 17:59:59 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-12-28 18:00:59 +0000

    Adds support for Purism coreboot keyboards

    On Purism coreboot systems the quirks mode in atkbdc prevents built in
    Keyboard from being used. Add quirk to prevent that.

    MFC After:              2 weeks
    PR:                     271737
    Reviewed by:            imp
    Differential Revision:  https://reviews.freebsd.org/D40405

    (cherry picked from commit 599a4548f8f1758afe1d33c53e9a56e42c5f3e30)

 sys/dev/atkbdc/atkbdc.c | 1 +
 1 file changed, 1 insertion(+)