Bug 271946 - math/singular: install the info file
Summary: math/singular: install the info file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-11 12:23 UTC by Thierry Thomas
Modified: 2023-06-11 20:52 UTC (History)
1 user (show)

See Also:
thierry: maintainer-feedback?


Attachments
Install the info file + doc and manpages + gfanlib (164.81 KB, patch)
2023-06-11 12:23 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2023-06-11 12:23:38 UTC
Created attachment 242730 [details]
Install the info file + doc and manpages + gfanlib

I'm still trying to upgrade the port math/sage, and for some reason it requires singular.info to be installed.

The attached patch does the following:

- install singular.info (do not try to build the documentation but grab the pre-built tarball)

- install the man pages again

- also enable gfanlib (optionally).
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-06-11 20:52:17 UTC
Hi Thierry,

Thank you for the patch.

I am committing a bit modified version with these changes:
1. Fix the bug in plist (missing %%GFAN%% prefix)
2. Use GFAN_CONFIGURE_ENABLE
3. Remove GFAN_RUN_DEPENDS (it isn't needed at runtime)
4. Use PORTDOCS=* to avoid adding all docs to plist


Best,
Yuri
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-06-11 20:52:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=86bbcd628c119ca7a9d715f71170a8953e0386a7

commit 86bbcd628c119ca7a9d715f71170a8953e0386a7
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-06-11 20:49:26 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-06-11 20:52:18 +0000

    math/singular: Add DOCS and GFAN options to enable docs and gfanlib module

    PR:             271946
    Submitted by:   thierry@ (initial patch)

 math/singular/Makefile                             | 28 ++++++++++++++++---
 math/singular/distinfo                             |  8 +++---
 math/singular/files/patch-Makefile.am (gone)       | 18 -------------
 .../files/patch-Singular_Makefile.am (gone)        | 12 ---------
 math/singular/files/patch-configure.ac (gone)      | 31 ----------------------
 math/singular/pkg-plist                            |  8 ++++--
 6 files changed, 35 insertions(+), 70 deletions(-)