Bug 272266 - multimedia/jellyfin: is dependency on openssl necessary?
Summary: multimedia/jellyfin: is dependency on openssl necessary?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dries Michiels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-28 10:35 UTC by Lapo Luchini
Modified: 2023-07-27 16:05 UTC (History)
2 users (show)

See Also:
michiel: maintainer-feedback+


Attachments
0001-multimedia-jellyfin-Dont-force-openssl-from-ports.patch (1.07 KB, patch)
2023-06-28 18:44 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff
0001-multimedia-jellyfin-Move-some-dependencies-to-USES.patch (1.25 KB, patch)
2023-07-27 10:16 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lapo Luchini 2023-06-28 10:35:13 UTC
Hi, I prefer to use system openssl so I was a little hesitant to install multimedia/jellyfin package, in the end I decided remove that dependency and compile it locally… it seems to work fine with system openssl 1.1.1t (instead of 1.1.1u from the Ports), at least on my FreeBSD 13.2/amd64.

Is the dependency on openssl really needed (maybe for some corner feature I didn't try yet), or maybe only on older systems?

BTW: thanks for the porting effort!
Comment 1 Michiel van Baak Jansen 2023-06-28 16:24:22 UTC
(In reply to Lapo Luchini from comment #0)

The only 'reason' is that most users update the installed package inside a jail, but they dont update their jail, so openssl becomes outdated.
But as you found out, the base openssl works fine.

I'll update the port to depend on ssl, no matter where it comes from :)
Comment 2 Michiel van Baak Jansen 2023-06-28 18:44:21 UTC
Created attachment 243063 [details]
0001-multimedia-jellyfin-Dont-force-openssl-from-ports.patch

Switch to 'Uses=ssl:run' instead of hard depending on the openssl port. base openssl works just as good.
Tested on 13.2 amd64 in a jail with the openssl port installed and in a jail without the openssl port installed.
'production' jail is now also running without the openssl port installed and so far 6 remote streams were completed successfully.

poudriere ok
Comment 3 Michiel van Baak Jansen 2023-07-27 10:16:41 UTC
Created attachment 243639 [details]
0001-multimedia-jellyfin-Move-some-dependencies-to-USES.patch

poudriere ok
runs in production on my setup (13.2 amd64)

Next to openssl, add sqlite:3 to USES instead of hardcoding the port in RUN_DEPENDS.
Triggered by 259252
Comment 4 Dries Michiels freebsd_committer freebsd_triage 2023-07-27 10:37:39 UTC
Take
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-07-27 16:04:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8eaad5a11770f1f52647c400471b967b9da36cae

commit 8eaad5a11770f1f52647c400471b967b9da36cae
Author:     Michiel van Baak Jansen <michiel@vanbaak.eu>
AuthorDate: 2023-07-27 15:57:57 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2023-07-27 16:03:28 +0000

    multimedia/jellyfin: switch to USES for sqlite and openssl

    PR:     272266

 multimedia/jellyfin/Makefile | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Comment 6 Dries Michiels freebsd_committer freebsd_triage 2023-07-27 16:05:34 UTC
Committed, thanks!