Bug 272349 - irc/inspircd fails to build with geo_maxmind module on freebsd 13.2
Summary: irc/inspircd fails to build with geo_maxmind module on freebsd 13.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dries Michiels
URL: https://www.freshports.org/irc/inspircd/
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-03 14:09 UTC by asher
Modified: 2023-08-29 09:00 UTC (History)
4 users (show)

See Also:
grahamperrin: maintainer-feedback? (driesm)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description asher 2023-07-03 14:09:44 UTC
hello there i have freebsd 13.2 and i try run inspircd version 4 in home when i run it without a module geo_maxmind is run good when i select run with a module then i get error even when i run it like this commands
gmake CXXFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib install
then i get error and this a error
Found the libmaxminddb compiler flags for geo_maxmind using pkg-config: -I/usr/local/include
Found the libmaxminddb linker flags for geo_maxmind using pkg-config: -L/usr/local/lib -lmaxminddb
        BUILD:          modules/m_geo_maxmind.cpp
In file included from /usr/home/asher/inspircd-4.0.0a21/src/modules/m_geo_maxmind.cpp:34:
In file included from /usr/home/asher/inspircd-4.0.0a21/include/inspircd.h:51:
In file included from /usr/include/c++/v1/sstream:184:
In file included from /usr/include/c++/v1/istream:163:
In file included from /usr/include/c++/v1/ostream:139:
In file included from /usr/include/c++/v1/ios:214:
/usr/include/c++/v1/__locale:676:16: fatal error: use of undeclared identifier 'isascii'
        return isascii(__c) ? (__tab_[static_cast<int>(__c)] & __m) !=0 : false;
               ^
1 error generated.
gmake[1]: *** [real.mk:478: modules/m_geo_maxmind.so] Error 1
gmake: *** [GNUmakefile:210: target] Error 2

i happy to know if this from a system or from other thanks for help
Comment 1 Mina Galić freebsd_triage 2023-07-03 14:19:27 UTC
^Triage: reassigning from base / virtualisation to ports
Comment 2 asher 2023-07-03 19:33:56 UTC
i need to know where i worng in here in commands or is this in a system freebsd?
Comment 3 Mina Galić freebsd_triage 2023-07-04 18:30:26 UTC
this is a bug in libmaxminddb: https://github.com/maxmind/libmaxminddb/issues/318
if the Maintainer doesn't respond, we might wanna patch that library ourselves.
adding sunpoet@ to CC, who is the maintainer of that port
Comment 4 Dries Michiels freebsd_committer freebsd_triage 2023-07-26 13:14:38 UTC
As inspircd maintainer, I'll take a look at providing a port option for libmaxminddb, as I see it is currently not available. (I will also check for other missing options).
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-07-26 17:49:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3a3ffe42735a8dc79156e8298dec8b03d263205

commit b3a3ffe42735a8dc79156e8298dec8b03d263205
Author:     Dries Michiels <driesm@FreeBSD.org>
AuthorDate: 2023-07-26 17:29:58 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2023-07-26 17:49:21 +0000

    irc/inspircd: add missing options

    PR:     272349

 irc/inspircd/Makefile | 29 +++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-08-16 18:37:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b0b6c960682cd256cfe227b648971b66ef1f2038

commit b0b6c960682cd256cfe227b648971b66ef1f2038
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2023-08-16 18:10:27 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2023-08-16 18:25:10 +0000

    net/libmaxminddb: Remove incorrect _POSIX_C_SOURCE

    - Bump PORTREVISION for package change

    PR:             272349
    Reported by:    Mina Galic <freebsd@igalic.co>
    Reference:      https://github.com/maxmind/libmaxminddb/issues/318

 net/libmaxminddb/Makefile                           |  1 +
 .../files/patch-include_maxminddb.h (new)           | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+)
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-08-16 19:22:48 UTC
(In reply to Mina Galić from comment #3)

Thanks for reporting. I've removed _POSIX_C_SOURCE from libmaxminddb after finishing building all the 37 dependent ports in poudriere.