Created attachment 243415 [details]
Diff updating ncmpc 0.41 to ncmpc 0.48

I just noticed that two of the patches in the previous versions were fixed upstream.

Created attachment 243416 [details]
Diff updating ncmpc 0.41 to ncmpc 0.48

I think I got the hang of it, I created a commit and made a diff against the previous commit. This diff should be right.

Comment 3 Fernando Apesteguía 2023-07-17 07:07:22 UTC

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A: PORTREVISION should be removed. NO NEED to update a new patch.


Thanks!

Comment 4 Fernando Apesteguía 2023-07-17 13:12:03 UTC

Hi Laurent,

Thanks for the patch. Unfortunately it does not build:

Compiler for C++ supports link arguments -Wl,--gc-sections: YES 
Run-time dependency threads found: YES
Library m found: YES
Run-time dependency libmpdclient found: YES 2.20
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency libpcre2-8 found: NO (tried pkgconfig)

meson.build:221:13: ERROR: Dependency "libpcre2-8" not found, tried pkgconfig

A full log can be found at /wrkdirs/usr/ports/audio/ncmpc/work/ncmpc-0.48/_build/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
===>  Script "configure" failed unexpectedly.
Please report the problem to laurent@nilio.ca [maintainer] and attach the
"/wrkdirs/usr/ports/audio/ncmpc/work/ncmpc-0.48/_build/meson-logs/meson-log.txt"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Could you have a look at it?

Created attachment 243430 [details]
Diff updating ncmpc 0..41 to ncmpc 0.48

Removed PORTREVISION and set the libpcre dependency to libpcre2. I will now setup poudriere to test it better in the future.

Comment 6 Fernando Apesteguía 2023-07-18 08:49:47 UTC

It's still failing. Would you mind building int in poudriere?

Created attachment 243552 [details]
Diff updating ncmpc 0.41 to ncmpc 0.48

The problem is that the port was looking for libpcre2-8.so. libpcre2.so does not exist.

Comment 8 Fernando Apesteguía 2023-07-24 06:04:57 UTC

(In reply to Laurent Cimon from comment #7)
===========================================================================
====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'lib/ncmpc/lyrics/30-karaoke_texty.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'lib/ncmpc/lyrics/40-tekstowo.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'lib/ncmpc/lyrics/60-google.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'lib/ncmpc/lyrics/51-supermusic.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'lib/ncmpc/lyrics/50-genius.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'lib/ncmpc/lyrics/20-azlyrics.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'lib/ncmpc/lyrics/52-zeneszoveg.py'
*** Error code 1

Please, can you run the port in poudriere? It is a great tool and saves a lot of time: https://docs.freebsd.org/en/books/porters-handbook/book/#testing-poudriere

Created attachment 243667 [details]
Diff updating ncmpc 0.41 to ncmpc 0.48

Okay, I had built it with poudriere previously but I hadn't used testport.

Now this builds fine and passes testport.

Thank you,
Laurent

Comment 10 Fernando Apesteguía 2023-08-02 06:10:45 UTC

Committed,

Thanks!

Comment 11 commit-hook 2023-08-02 06:11:17 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1d7aaa5de2b65ada83e7956867f1d72c6ba5c063

commit 1d7aaa5de2b65ada83e7956867f1d72c6ba5c063
Author:     Laurent Cimon <laurent@nilio.ca>
AuthorDate: 2023-07-29 17:16:37 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-08-02 06:10:14 +0000

    audio/ncmpc: Update to 0.48

    ChangeLog: https://github.com/MusicPlayerDaemon/ncmpc/blob/master/NEWS

    Accumulated changes:

    * drop support for ~/.ncmpc/; using only ~/.config/ncmpc/ (XDG)
    * improve scroll-offset handling
    * experimental table layout
    * handle Ctrl-C in search prompt
    * link with libintl and libiconv if necessary
    * require libmpdclient 2.16 or newer
    * require MPD 0.21 or newer
    * switch to C++20
    * eliminate Boost dependency
    * install Lithuanian translation
    * migrate to PCRE2
    * make "tagtypes" errors non-fatal
    * check which tag types are supported by MPD (fixes MPD 0.21 support)
    * lyrics: update page title after loading has finished
    * lyrics: fix path injection bug
    * lyrics: load cached lyrics without plugin
    * lyrics: use $XDG_CACHE_HOME/ncmpc/lyrics instead of ~/.lyrics
    * lyrics/azlyrics: normalize accented letters (using the "unidecode" library)
    * lyrics/azlyrics: unescape HTML entities
    * fix scrolling problems on help page
    * highlight find results on help page
    * don't attempt IPv6 connection if IPv6 routing is disabled
    * support MPD 0.22 tags "conductor", "work", "grouping" (requires
      libmpdclient 2.17)
    * show "conductor" and "work" on song page
    * playlist editor (work in progress)
    * file page: handle mouse double clicks
    * fix crash bug
    * fix build failure on macOS
    * add azlyrics plugin
    * file page: repaint after moving cursor with mouse
    * file page: handle mouse click on directory
    * library page: mouse support
    * support the mouse wheel
    * fix assertion failure on exit

    PR:             272527
    Reported by:    laurent@nilio.ca (maintainer)

 audio/ncmpc/Makefile                                 | 11 +++++------
 audio/ncmpc/distinfo                                 |  6 +++---
 audio/ncmpc/files/patch-src_plugin.cxx (new)         | 11 +++++++++++
 audio/ncmpc/files/patch-src_screen__utils.cxx (gone) | 10 ----------
 audio/ncmpc/files/patch-src_signals.cxx (gone)       | 11 -----------
 audio/ncmpc/pkg-plist                                | 13 ++++++++++++-
 6 files changed, 31 insertions(+), 31 deletions(-)