Bug 272531 - security/veracrypt: does not compile on FreeBSD 14
Summary: security/veracrypt: does not compile on FreeBSD 14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-16 06:46 UTC by Lutz Bichler
Modified: 2023-07-17 23:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (acm)

Attachments
Add -std=c++11 to CXXFLAGS (1.80 KB, patch)
2023-07-16 06:46 UTC, Lutz Bichler 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lutz Bichler 2023-07-16 06:46:01 UTC 
Created attachment 243417 [details]
Add -std=c++11 to CXXFLAGS

std::byte from C++17 conflicts with internal type definitions. Adding -std=c++11 to the C++ flags fixes the problem (see attached patch).
Comment 1 Mina Galić freebsd_triage 2023-07-16 08:46:59 UTC 
did you report this upstream?
Comment 2 Lutz Bichler 2023-07-16 13:50:00 UTC 
(In reply to Mina Galić from comment #1)
No, I didn´t.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-07-16 20:26:20 UTC 
Unless upstream ignores CXXFLAGS (which should be fixed if that the case) use "USE_CXXSTD= c++11" in the port Makefile instead.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-07-16 20:27:36 UTC 
(In reply to Daniel Engberg from comment #3)
if that the case --> if that is the case

Reference: https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n354
Comment 5 Lutz Bichler 2023-07-17 16:38:14 UTC 
(In reply to Daniel Engberg from comment #3)
Setting ""USE_CXXSTD= c++11" in the port makefile does not work for me. What is the problem with changing the already existing patch to the upstream Makefile?
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-07-17 23:22:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=45f0113f4c6a3921e14a1a3fb1c201f0b3e68c9d

commit 45f0113f4c6a3921e14a1a3fb1c201f0b3e68c9d
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2023-07-17 23:19:15 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2023-07-17 23:19:15 +0000

    security/veracrypt: Fix build on 14.x

    - Bump PORTREVISION

    PR:             272531
    Reported by:    Lutz Bichler <Lutz.Bichler _at_ gmail.com>

 security/veracrypt/Makefile                 |  2 ++
 security/veracrypt/files/patch-src_Makefile | 12 ++++++++----
 2 files changed, 10 insertions(+), 4 deletions(-)
Comment 7 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2023-07-17 23:23:50 UTC 
I have committed a patch file. It should be work right now. Thanks for your PR!