Bug 272645 - www/node18: Unbreak clang16 on aarch64
Summary: www/node18: Unbreak clang16 on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-21 18:37 UTC by Nuno Teixeira
Modified: 2023-07-25 06:50 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Unbreak aarch64 (666 bytes, patch)
2023-07-21 18:37 UTC, Nuno Teixeira 		no flags Details | Diff
Use COMPILER_VERSION check (469 bytes, patch)
2023-07-24 19:24 UTC, Nuno Teixeira 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2023-07-21 18:37:34 UTC 
Created attachment 243531 [details]
Unbreak aarch64

Some work was done to fixes it upstream but it continues to fail on aarch64.

---
error: integer value 31 is outside the valid range of values [0, 15] for the enumeration type 'AddressingMode' [-Wenum-constexpr-conversion]
---

Inspired by: https://cgit.freebsd.org/ports/commit/?id=ee3e6d5a17a0c78bb56f8d5719de82b8dd49950d
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-21 19:35:51 UTC 
(In reply to Nuno Teixeira from comment #1)
(...)

Forgot error log:
https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.1.log
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-24 19:24:18 UTC 
Created attachment 243594 [details]
Use COMPILER_VERSION check

- Use '.if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 160 && ${ARCH} == aarch64' rather than depending on only OSVERSION
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-25 06:49:40 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a315d93d509a19c72ad9bf76a9b903e8f4cb6f80

commit a315d93d509a19c72ad9bf76a9b903e8f4cb6f80
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-07-25 06:46:11 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-07-25 06:48:01 +0000

    www/node18: Fix build with llvm16 on aarch64

    PR:             272645
    Approved by:    portmgr (blanket)

 www/node18/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-25 06:50:28 UTC 
Committed.