Bug 272657 - math/nauty: Remove NATIVE option
Summary: math/nauty: Remove NATIVE option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-22 09:57 UTC by Daniel Engberg
Modified: 2023-10-21 14:54 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (moritz)

Attachments
Patch for nauty (1.60 KB, patch)
2023-07-22 09:57 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-07-22 09:57:00 UTC 
Created attachment 243541 [details]
Patch for nauty

This breaks on non amd64 platforms and we already have CPUTYPE that handles this type of optimization.

Use "safe" optimization for all platforms

Compile and runtime tested on FreeBSD 13.2-RELEASE (aarch64) (make, make check-plist, make test)
Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test)
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-23 17:16:14 UTC 
^Triage: reporter is committer, assign accordingly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-21 14:45:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5526837674995dd0eb7ce5dbeb4d7dd1735db77

commit a5526837674995dd0eb7ce5dbeb4d7dd1735db77
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-10-21 14:41:23 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-10-21 14:43:23 +0000

    math/nauty: Remove NATIVE option

    This breaks on non amd64 platforms and we already have CPUTYPE that
    handles this type of optimization.

    Use "safe" optimization for all platforms

    PR:             272657
    Approved by:    portmgr (maintainer timeout, 2+ months)

 math/nauty/Makefile | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)