Patches to be supplied shortly.
Created attachment 243544 [details] Updated patch for src/blackbox.cc
Created attachment 243545 [details] Updated patch for src/Screen.cc
Hi Trond, Isn't this something that should better be sent upstream?
Approved without testing based on review of changes. Thank you, Trond. Fernando, Blackbox development stopped a while ago with the release of 0.70.1 in November 2005. See https://github.com/bradleythughes/blackbox/tags There have been some subsequent efforts to update the code, but none appear to have revived or taken over the project.
(In reply to Andrew J. Caines from comment #4) OK, It could be nice if at least we could also send this upstream to some of those repos (wikipedia mentions this one: https://github.com/bbidulock/blackboxwm/tree/master). Thanks.
Trond, Could yo attach a patch *to the port itself*?
Fernando, You are quite right that updates which apply to any active upstream projects should be shared with them, however these changes appear to me to be changes specific to (the compiler now used on) FreeBSD and so belong only in the port. I defer to Trond and others better qualified than I on this assessment. You should feel free to share these any all other changes[1] which have not yet been incorporated into any active upstream projects (despite being available for decades). FWIW I see that Fedora uses Brian Bidulock's fork[2] for its package, but note that it appears to already include maintenance changes from multiple sources and is not an active project. Since this bug report is not the place for this discussion, I suggest posting to the FreeBSD Ports list[3] with the results of your efforts. I'm only 6839 messages behind on FreeBSD lists, so I will see it... eventually. [1] See https://github.com/freebsd/freebsd-ports/tree/main/x11-wm/blackbox/files [2] https://github.com/bbidulock/blackboxwm [3] https://lists.freebsd.org/subscription/freebsd-ports
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1bd91c34660f630db4d1414a2d64b47162a5baad commit 1bd91c34660f630db4d1414a2d64b47162a5baad Author: Trond Endrestol <Trond.Endrestol@ximalas.info> AuthorDate: 2023-07-27 06:48:20 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-07-28 06:32:51 +0000 x11-wm/blackbox: switch from std::mem_fun to std::mem_fn The former is deprecated. PR: 272660 Reported by: Trond.Endrestol@ximalas.info Approved by: A.J.Caines@halplant.com (maintainer) x11-wm/blackbox/Makefile | 2 +- x11-wm/blackbox/files/patch-src_Screen.cc | 24 ++++++++++++++++++++++++ x11-wm/blackbox/files/patch-src_blackbox.cc | 25 +++++++++++++++++++++++++ 3 files changed, 50 insertions(+), 1 deletion(-)
Committed, Thanks!
Thank you Fernando and thank you again Trond.