Bug 272700 - security/fcrackzip: Switch to fork that utilizes libzip
Summary: security/fcrackzip: Switch to fork that utilizes libzip
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-24 19:36 UTC by Daniel Engberg
Modified: 2023-08-05 19:24 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bofh)

Attachments
Patch for fcrackzip (6.38 KB, patch)
2023-07-24 19:36 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-07-24 19:36:40 UTC 
Created attachment 243596 [details]
Patch for fcrackzip

Performance is a lot better than using unzip externally

Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64)
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-08-05 19:17:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=45c9ee77bf78aec4c4f078dffab74ae6555186ae

commit 45c9ee77bf78aec4c4f078dffab74ae6555186ae
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-08-05 19:12:30 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-08-05 19:16:15 +0000

    security/fcrackzip: Switch to fork that utilizes libzip

    Instead of launching unzip external for each try utilize libzip
    for much better performance

    PR:             272700
    Approved by:    bofh (private conversation)

 security/fcrackzip/Makefile                      |  20 +++-
 security/fcrackzip/distinfo                      |   5 +-
 security/fcrackzip/files/patch-crack.h (gone)    |  10 --
 security/fcrackzip/files/patch-fcrackzip.1 (new) |  22 ++++
 security/fcrackzip/files/patch-main.c            | 134 ++++-------------------
 5 files changed, 58 insertions(+), 133 deletions(-)