Bug 272765 - Cleanup debugging code in libm
Summary: Cleanup debugging code in libm
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Konstantin Belousov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-27 21:18 UTC by Steve Kargl
Modified: 2023-10-02 16:19 UTC (History)
2 users (show)

See Also:


Attachments
patch to remove debugging code (13.33 KB, patch)
2023-07-27 21:18 UTC, Steve Kargl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Kargl freebsd_committer freebsd_triage 2023-07-27 21:18:35 UTC
Created attachment 243657 [details]
patch to remove debugging code

David Das (das@) committed Bruce Evan's (bde's) WIP code for
expl() and logl() in git revision 25a4d6bfda29119.  That code
included instrumentation that allowed bde to generate pari
scripts used in testing/debugging.  This patch removes that
instrumentation as it is unlikely that others will ever use it.

 
* math/libm/msun/src/math_private.h:
  . Remove bde's macros for the generation of pari scripts.

* math/libm/msun/ld128/s_expl.c:
* math/libm/msun/ld128/s_logl.c:
* math/libm/msun/ld80/s_expl.c:
* math/libm/msun/ld80/s_logl.c:
  . Remove bde's DOPRINT_START macro.
  . Change RETURNP to RETURNF.
  . Change RETURN2P to RETURNF.  Adjust arguments as needed.
  . Change RETURNPI to RETURNI.
  . Change RETURN2PI to RETURNI.  Adjust arguments as needed.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-08-03 05:10:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c66a499e037efd268a744e487e7d0c45a4944a9b

commit c66a499e037efd268a744e487e7d0c45a4944a9b
Author:     Steve Kargl <kargl@FreeBSD.org>
AuthorDate: 2023-07-31 22:32:54 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2023-08-03 04:27:58 +0000

    Cleanup debugging code in libm

    David Das (das@) committed Bruce Evan's (bde's) WIP code for
    expl() and logl() in git revision 25a4d6bfda29119.  That code
    included instrumentation that allowed bde to generate pari
    scripts used in testing/debugging.  This patch removes that
    instrumentation as it is unlikely that others will ever use it.

    * math/libm/msun/src/math_private.h:
      . Remove bde's macros for the generation of pari scripts.

    * math/libm/msun/ld128/s_expl.c:
    * math/libm/msun/ld128/s_logl.c:
    * math/libm/msun/ld80/s_expl.c:
    * math/libm/msun/ld80/s_logl.c:
      . Remove bde's DOPRINT_START macro.
      . Change RETURNP to RETURNF.
      . Change RETURN2P to RETURNF.  Adjust arguments as needed.
      . Change RETURNPI to RETURNI.
      . Change RETURN2PI to RETURNI.  Adjust arguments as needed.

    PR:     272765
    MFC after:      1 week

 lib/msun/ld128/s_expl.c     |  28 +++++------
 lib/msun/ld128/s_logl.c     |  24 ++++-----
 lib/msun/ld80/s_expl.c      |  28 +++++------
 lib/msun/ld80/s_logl.c      |  26 +++++-----
 lib/msun/src/math_private.h | 115 ++------------------------------------------
 5 files changed, 49 insertions(+), 172 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-10 02:59:02 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1d488ee57aa193bb10337972c9ced440017806de

commit 1d488ee57aa193bb10337972c9ced440017806de
Author:     Steve Kargl <kargl@FreeBSD.org>
AuthorDate: 2023-07-31 22:32:54 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2023-08-10 02:57:29 +0000

    Cleanup debugging code in libm

    PR:     272765

    (cherry picked from commit c66a499e037efd268a744e487e7d0c45a4944a9b)

 lib/msun/ld128/s_expl.c     |  28 +++++------
 lib/msun/ld128/s_logl.c     |  24 ++++-----
 lib/msun/ld80/s_expl.c      |  28 +++++------
 lib/msun/ld80/s_logl.c      |  26 +++++-----
 lib/msun/src/math_private.h | 115 ++------------------------------------------
 5 files changed, 49 insertions(+), 172 deletions(-)