Bug 272928 - misc/tzdiff: Remove LICENSE_FILE
Summary: misc/tzdiff: Remove LICENSE_FILE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-04 01:52 UTC by Yuichiro NAITO
Modified: 2023-08-06 12:50 UTC (History)
2 users (show)

See Also:

Attachments
Remove LICENSE patch (605 bytes, text/plain)
2023-08-04 01:52 UTC, Yuichiro NAITO 		naito.yuichiro: maintainer-approval+
Details
Remove LICESNSE_FILE patch (605 bytes, text/plain)
2023-08-06 01:49 UTC, Yuichiro NAITO 		naito.yuichiro: maintainer-approval+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuichiro NAITO 2023-08-04 01:52:58 UTC 
Created attachment 243831 [details]
Remove LICENSE patch

I've got a error message from pkg-fallout@FreeBSD.org.

```
===>  Missing license file for BSD2CLAUSE in /wrkdirs/usr/ports/misc/tzdiff/work/tzdiff-1.2/LICENSE
*** Error code 1

Stop.
make: stopped in /usr/ports/misc/tzdiff
```

The original repository of misc/tzdiff doesn't have 'LICENSE' file.
Please remove 'LICENSE_FILE' entry from Makefile. The license sentences
are written in the tzdiff shell script body.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-08-05 11:47:48 UTC 
Thanks for spotting this.  It appears that the previous patch was insufficiently tested.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-08-05 12:27:17 UTC 
...or just backport 3a5679b8adbf4cc450dfde321db9c41c9a02bef2 for now

I just looked at the repo, not the specific tag. Sorry :/
Comment 3 Yuichiro NAITO 2023-08-06 01:49:29 UTC 
Created attachment 243877 [details]
Remove LICESNSE_FILE patch

Changed patch description.
Comment 4 Yuichiro NAITO 2023-08-06 01:52:59 UTC 
I think just removing LICENSE_FILE line is enough to poudriere build. I confirmed
my poudriere build finished successfully with my patch. I missed my patch file
description. I fixed it from 'LICENSE' to 'LICENSE_FILE'.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-08-06 12:44:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=849abbb28281aadfae9d3b1b5f80c947d6e0f9e8

commit 849abbb28281aadfae9d3b1b5f80c947d6e0f9e8
Author:     Yuichiro NAITO <naito.yuichiro@gmail.com>
AuthorDate: 2023-08-05 11:46:13 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-08-06 12:42:47 +0000

    misc/tzdiff: remove bogus LICENSE_FILE

    The license is present in the repo but not in the tagged release.

    PR:             272928
    Fixes:          99af3eef26c5b97f692bc3c56a62509d65d92d38

 misc/tzdiff/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-08-06 12:50:24 UTC 
Thank you for your contribution.