Bug 273316 - math/polymake: Remove NATIVE option
Summary: math/polymake: Remove NATIVE option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-23 20:29 UTC by Philipp Ost
Modified: 2023-10-08 09:45 UTC (History)
2 users (show)

See Also:
bsd: maintainer-feedback+

Attachments
math/polymake: remove NATIVE option (1.74 KB, patch)
2023-08-23 20:29 UTC, Philipp Ost 		bsd: maintainer-approval+
Details | Diff
Additional fixes to port (2.80 KB, patch)
2023-09-02 05:30 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2023-08-23 20:29:32 UTC 
Created attachment 244302 [details]
math/polymake: remove NATIVE option

Remove NATIVE option, bump PORTREVISION due to change in available options.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2023-08-26 16:18:12 UTC 
NATIVE is not enabled by default, and packages are built without it.
Why do you want to remove this option?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-08-26 18:18:15 UTC 
There have been instances where -march=native makes mistakes and produces broken binaries and on top of that it only works on amd64/i386. People should make use of CPUTYPE instead which is supported be the framework if they want optimized binaries.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-09-02 05:30:03 UTC 
Created attachment 244571 [details]
Additional fixes to port

Add GitHub as primary download site and polymake.org as fallback
Respect CFLAGS, O3 optimization should be a menu toggle (if it makes any difference in performance at all)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-09-02 05:31:45 UTC 
Reference: https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags

Sorry for the late reply
Comment 5 Philipp Ost 2023-09-04 20:00:46 UTC 
Comment on attachment 244571 [details]
Additional fixes to port

Looks good. Thanks for the additional updates!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-08 09:41:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96e194fafea582015e3d14ec48653a4734a1a15c

commit 96e194fafea582015e3d14ec48653a4734a1a15c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-10-08 09:27:59 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-10-08 09:40:40 +0000

    math/polymake: Remove NATIVE option and add GitHub to MASTER_SITES

    * Add GitHub as primary download site and upstream website as backup
    * Remove NATIVE option, users wanting to apply CPU specific optimization
    should use CPUTYPE instead using ports framework
    * Use OPTIMIZED_CFLAGS option to define O3 optimization

    PR:             273316
    Reviewed by:    Philipp Ost <bsd@philippost.de> (maintainer)
    Sponsored by:   Blinkinblox

 math/polymake/Makefile                               | 14 ++++++++------
 math/polymake/files/patch-support_configure.pl (new) | 11 +++++++++++
 2 files changed, 19 insertions(+), 6 deletions(-)
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2023-10-08 09:45:02 UTC 
Committed, thanks!