Bug 273319 - x11-wm/compton: compton-trans uses invalid POSIX grep expressions
Summary: x11-wm/compton: compton-trans uses invalid POSIX grep expressions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-24 01:22 UTC by Duane
Modified: 2023-09-24 19:01 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-


Attachments
Convert sed to BRE (1.82 KB, patch)
2023-08-24 01:22 UTC, Duane
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Duane 2023-08-24 01:22:10 UTC
Created attachment 244305 [details]
Convert sed to BRE

I have had an open bug report for around 8 years now on the main project, with no progress.  Hoping that maybe we can fix this here instead.

The simplest solution is to append the switch `-E` to every call to sed (I haven't tested this, but assume it will work), or alternatively the attached patch modifies the regular expressions to only use valid BRE expressions.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-09-22 19:37:33 UTC
maintainer timeout

Could it be that the patch is the wrong way round?  I.e. old and new file are swapped?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-09-22 19:41:41 UTC
On another note, it seems like the maintainer of this one has been AWOL for a while.  Could I interest you in adopting the port?
Comment 3 Duane 2023-09-23 06:06:26 UTC
Sorry, you are correct, the patch is reversed.

I'm not been a maintainer for anything before, but I suppose I should consider it given that I'm comfortable submitting patches.  Is there a crash course somewhere on what I need to do?  I assume I maybe need to track ports HEAD and submit PRs somewhere?
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-09-23 06:21:33 UTC
(In reply to Duane from comment #3)

As the maintainer, you'll be responsible for keeping the port in working order and updating it if upstream submits a new release.  If there are bug reports, it would be nice if you could try and fix them.  You also have the responsibility to check and if appropriate, approve patches others submit for your port.

You can quit any time.  It's nice to have someone who takes care of some things.

There isn't really a crash course.  If you have questions, join #bsdports on EFnet or #freebsd-ports on libera.chat

Let me know when you have decided.

Your patch is slated to be committed with my next batch.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-09-24 19:00:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0816318fd77ec41759affa9e42aac2a2603186a1

commit 0816318fd77ec41759affa9e42aac2a2603186a1
Author:     Duane <parakleta@darkreality.org>
AuthorDate: 2023-09-22 19:39:29 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-24 18:57:14 +0000

    x11-wm/compton: use basic regex for compton-trans

    The compton-trans script makes use of extended regex features sed(1)
    does not support.  Patch it to use BREs only.

    While we are at it, do some housekeeping on the port Makefile.

    PR:             273319
    Approved by:    femc7488@gmail.com (maintainer timeout)

 x11-wm/compton/Makefile                            |  7 ++-
 x11-wm/compton/files/patch-bin_compton-trans (new) | 60 ++++++++++++++++++++++
 2 files changed, 63 insertions(+), 4 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-09-24 19:01:37 UTC
Thank you for your contribution.