Bug 273390 - [New Port] x11-wm/fswm fullscreen window manager in libxcb
Summary: [New Port] x11-wm/fswm fullscreen window manager in libxcb
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-27 22:43 UTC by pyrus
Modified: 2023-09-07 15:22 UTC (History)
2 users (show)

See Also:


Attachments
x11-wm/fswm patch including Makefile, pkg-descr, distinfo and addition of category (2.37 KB, patch)
2023-08-27 22:43 UTC, pyrus
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pyrus 2023-08-27 22:43:45 UTC
Created attachment 244400 [details]
x11-wm/fswm patch including Makefile, pkg-descr, distinfo and addition of category

fswm is a fullscreen window manager in libxcb. The reason a Makefile was written for this is, because it uses the xcb library. Thank you
Comment 1 pyrus 2023-08-29 17:30:08 UTC
Recommended for use with x11/sxhkd and x11/thingylaunch.
Comment 2 pyrus 2023-09-01 19:53:52 UTC
I'll be the maintainer of this one, as that's already in the Makefile. Also, in the near future, I'll add optional dependencies of sxhkd and thingylaunch to make it easier to navigate and use commands.

Reason for porting this one, is because it's in XCB. That makes it lighter than similar programs. In this case, RESident memory use is 2260K, compared to 3476 of antiwm. Also, fswm works better with sxhkd and thingylaunch, making it more adaptable. antiwm doesn't seem to work well with thingylaunch. fswm also has simpler defaults.

Since I haven't taken maintenance-ship yet, until the patch is uploaded, do I set the flag on it? Better to wait until?
Comment 3 pyrus 2023-09-03 13:57:49 UTC
The program is started by "exec fswm xvt" or replace xvt with many other terminal emulators on the last line of .xsession or .xinitrc. When it's started like this, ctrl-alt-t starts a new window, using this terminal emulator. alt-tab shifts windows. ctrl-alt-delete ends the session.

thingylaunch and sxhkd are useful but not needed. They're good to have a way to navigate when the keys aren't understood yet.
Comment 4 Joseph Mingrone freebsd_committer freebsd_triage 2023-09-07 03:40:51 UTC
Looks good.

I made a few changes:

1. Add libxcb-util.so:x11/xcb-util to LIB_DEPENDS because

# readelf -a /usr/local/bin/fswm | grep libxcb-util
 0x0000000000000001 NEEDED               Shared library: [libxcb-util.so.1]

2. Add DOCS option

3. Split CFLAGS and LDFLAGS/LDLIBS

4. Add off-by-default run-time dependencies on x11/sxhkd and x11/thingylaunch

If you don't see any issues with https://reviews.freebsd.org/D41765 we can add it to the tree.

Thanks for submitting.
Comment 5 pyrus 2023-09-07 04:46:08 UTC
It's a good addition. Similar results in a different way. It didn't need GCC, and it's specified in a clearer way.

The shared library, I left out before, because the other dependency called it in. It's better to stay in.

sxhkd had gmake as a dependency. It's good that it's not a default option. It was for those comfortable using sxhkd before figuring out the window commands.

Compiled updated Makefile and ran in Xephyr.

The updated Makefile is good to go. The timestamp on the distfile may vary.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-09-07 09:54:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b40fb3c5c6ba52817cfa984fe8f440d554efff8a

commit b40fb3c5c6ba52817cfa984fe8f440d554efff8a
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2023-08-27 17:34:17 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2023-09-07 09:54:08 +0000

    x11-wm/fswm: Fullscreen window manager in XCB

    https://github.com/pbizopoulos/fswm

    PR:             273390
    Submitted by:   pyrus@bsdmail.com (original patch)

 x11-wm/Makefile             |  1 +
 x11-wm/fswm/Makefile (new)  | 43 +++++++++++++++++++++++++++++++++++++++++++
 x11-wm/fswm/distinfo (new)  |  3 +++
 x11-wm/fswm/pkg-descr (new) |  2 ++
 4 files changed, 49 insertions(+)
Comment 7 Joseph Mingrone freebsd_committer freebsd_triage 2023-09-07 09:56:34 UTC
Thank you!
Comment 8 pyrus 2023-09-07 15:22:04 UTC
Thank you