Bug 273406 - x11/wmenu: drop libepoll-shim on FreeBSD >= 14.0
Summary: x11/wmenu: drop libepoll-shim on FreeBSD >= 14.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-28 17:19 UTC by Jan Beich
Modified: 2023-09-03 12:47 UTC (History)
1 user (show)

See Also:
o.hushchenkov: maintainer-feedback+

Attachments
v1 (apply via "git am") (1.22 KB, patch)
2023-08-28 17:19 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-08-28 17:19:22 UTC 
Created attachment 244425 [details]
v1 (apply via "git am")

After base af93fea71038 the port builds fine without it. Also, annotate when to remove the conditional to help portmgr@ clean up in future.
Comment 1 Oleh Hushchenkov 2023-08-28 17:30:50 UTC 
Hi Jan,

I'm ok with the change. Still not managed to switch from 13-STABLE to 14-STABLE yet, so can't test.

Thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-28 17:36:21 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37db1d20057263b20edc3002280128753ea00c4d

commit 37db1d20057263b20edc3002280128753ea00c4d
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-27 08:24:44 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-08-28 17:34:21 +0000

    x11/wmenu: drop unused dependency on FreeBSD >= 14.0

    PR:             273406
    Approved by:    Oleh Hushchenkov (maintainer)

 x11/wmenu/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2023-08-28 17:49:41 UTC 
(In reply to Oleh Hushchenkov from comment #1)
> Still not managed to switch from 13-STABLE to 14-STABLE yet

x11/wmenu currently fails to build[1] due to bug 273373. The change will neither help no regress: devel/libepoll-shim no longer installs /usr/local/include/libepoll-shim/sys/timerfd.h. However, it's possible to work around by patching wmenu source to include <sys/types.h> before _POSIX_C_SOURCE.

[1] https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p157c391cc1f5_s023ef8015e/logs/errors/wmenu-0.1.4.log
Comment 4 Jan Beich freebsd_committer freebsd_triage 2023-08-28 17:53:21 UTC 
(In reply to Jan Beich from comment #3)
> The change will neither help no regress:

By "the change" (forgot to add "here") I meant this bug. It was tested with a fixed <sys/timerfd.h> e.g.,

$ zfs rollback tank/poudriere/jails/main-amd64@clean
$ ee /poudriere/jails/main-amd64/usr/include/sys/timerfd.h
$ zfs destroy tank/poudriere/jails/main-amd64@clean
$ zfs snapshot tank/poudriere/jails/main-amd64@clean
$ poudriere testport -j main-amd64 x11/wmenu
Comment 5 Oleh Hushchenkov 2023-08-28 18:17:15 UTC 
(In reply to Jan Beich from comment #3)

I saw pkg-fallout email this morning, but not investigate it yet.
Thanks for the hint, will fix as soon as be able to test it on 14-STABLE.
Comment 6 Jan Beich freebsd_committer freebsd_triage 2023-09-03 12:47:42 UTC 
Worked around in ports f4c28b489119, etc. I'll keep those until stable/14 receives the base fix before reverting. Old -CURRENT and -STABLE snapshots are not supported by re@ or portmgr@, and the package cluster always updates base system before build.