Bug 273468 - Mk/Uses/cargo.mk: strips leading "v" from "tag" values even if it's part of a word
Summary: Mk/Uses/cargo.mk: strips leading "v" from "tag" values even if it's part of a...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Rust Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-31 03:21 UTC by Jan Beich
Modified: 2023-10-02 11:35 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-08-31 03:21:37 UTC 
$ cd games/veloren-weekly
$ make cargo-crates-merge
$ make
[...]
===>  Configuring for veloren-weekly-s20230830
===>   Cargo config:
find: /usr/ports/games/veloren-weekly/work/egui_winit_platform-eloren-winit-0.28: No such file or directory
find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
[...]
[patch.'https://gitlab.com/Imbris/keyboard-keynames.git']
keyboard-keynames = { path = '/usr/ports/games/veloren-weekly/work/keyboard-keynames-veloren-winit-0.28-fca4bbdfa51bf054b155a455935b3792975c989d' }
[...]
[patch.'https://github.com/Imberflur/egui_winit_platform.git']
egui_winit_platform = { path = '/usr/ports/games/veloren-weekly/work/egui_winit_platform-eloren-winit-0.28' }
[...]
[patch.'https://github.com/Imberflur/iced']
iced_core = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
iced_futures = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
iced_graphics = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
iced_native = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
iced_style = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
iced_winit = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
[...]
===>   Updating Cargo.lock
error: failed to load source for dependency `iced_core`

Caused by:
  Unable to update /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28

Caused by:
  failed to read `/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
*** Error code 101

Stop.
make[1]: stopped in /usr/ports/games/veloren-weekly
*** Error code 1
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-10-02 11:34:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6b1b157425932c2977c10a53c090101215c8ad5e

commit 6b1b157425932c2977c10a53c090101215c8ad5e
Author:     Tobias Kortkamp <tobik@FreeBSD.org>
AuthorDate: 2023-09-30 08:38:19 +0000
Commit:     Tobias Kortkamp <tobik@FreeBSD.org>
CommitDate: 2023-10-02 11:33:25 +0000

    cargo.mk: Strip vV from GitHub tags only when followed by a digit

    Fixes the following in games/veloren-weekly when iced crates have a tag
    similar to veloren-winit-0.28

    $ cd games/veloren-weekly
    $ make cargo-crates-merge
    $ make
    [...]
    ===>  Configuring for veloren-weekly-s20230830
    ===>   Cargo config:
    find: /usr/ports/games/veloren-weekly/work/egui_winit_platform-eloren-winit-0.28: No such file or directory
    find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
    find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
    find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
    find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
    find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
    find: /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28: No such file or directory
    [...]
    [patch.'https://gitlab.com/Imbris/keyboard-keynames.git']
    keyboard-keynames = { path = '/usr/ports/games/veloren-weekly/work/keyboard-keynames-veloren-winit-0.28-fca4bbdfa51bf054b155a455935b3792975c989d' }
    [...]
    [patch.'https://github.com/Imberflur/egui_winit_platform.git']
    egui_winit_platform = { path = '/usr/ports/games/veloren-weekly/work/egui_winit_platform-eloren-winit-0.28' }
    [...]
    [patch.'https://github.com/Imberflur/iced']
    iced_core = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
    iced_futures = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
    iced_graphics = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
    iced_native = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
    iced_style = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
    iced_winit = { path = '/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28' }
    [...]
    ===>   Updating Cargo.lock
    error: failed to load source for dependency `iced_core`

    Caused by:
      Unable to update /usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28

    Caused by:
      failed to read `/usr/ports/games/veloren-weekly/work/iced-eloren-winit-0.28/Cargo.toml`

    Caused by:
      No such file or directory (os error 2)
    *** Error code 101

    Stop.
    make[1]: stopped in /usr/ports/games/veloren-weekly

    PR:             273468
    Reported by:    jbeich

 Mk/Scripts/cargo-crates-git-common.awk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)