Created attachment 244559 [details] updated dependency (configurable, on by default) Tumbler is being used for creating thumbnails, but doesn't get installed with Ristretto since only Thunar depends on first one. Adding a run dependency for those who doesn't use Thunar.
I'm not sure I understand fully. Is ristretto failing to show thumbnails in its own window if tumbler is not present? It that's the case I agree a runtime dep makes sense. Although I'd change the option wording slightly t: Install Tumbler dependency for creating thumbnails. "Use" does not look correct for the options, since tumbler will be used if already present whatever the option, that is, disabling the option will not prevent tumbler usage. SO my description more correctly describes what the option actually does.
(In reply to Guido Falsi from comment #1) > Is ristretto failing to show thumbnails in its own window if tumbler is not present? Exactly, and it even explicitly suggests installing Tumbler. Regarding latter: agreed with wording, you're absolutely right it will use Tumbler just if detected (I believe detection is done through D-Bus). And it's not required to link with libtumbler, thus RUN_DEPENDS instead of LIB_ one.
Comment on attachment 244559 [details] updated dependency (configurable, on by default) Approving patch with minor changes. Will commit once done with standard testing.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b7ca0e85105a9ac68a9d9ea1bdac98dfcf766333 commit b7ca0e85105a9ac68a9d9ea1bdac98dfcf766333 Author: Anton Saietskii <vsasjason@gmail.com> AuthorDate: 2023-09-02 09:38:11 +0000 Commit: Guido Falsi <madpilot@FreeBSD.org> CommitDate: 2023-09-02 09:38:11 +0000 graphics/ristretto: Add optional tumbler dependency Ristretto uses xfce tumbler service via dbus to generate thumbnails. This adds a new TUMBLER option (on by defualt) to set an explicit runtime dependency for tumbler. PR: 273496 graphics/ristretto/Makefile | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Patch committed. Thanks!
A commit in branch 2023Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=161c8368dc2326187d48d0f026f0212e961ab857 commit 161c8368dc2326187d48d0f026f0212e961ab857 Author: Anton Saietskii <vsasjason@gmail.com> AuthorDate: 2023-09-02 09:38:11 +0000 Commit: Guido Falsi <madpilot@FreeBSD.org> CommitDate: 2023-09-02 09:56:51 +0000 graphics/ristretto: Add optional tumbler dependency Ristretto uses xfce tumbler service via dbus to generate thumbnails. This adds a new TUMBLER option (on by defualt) to set an explicit runtime dependency for tumbler. PR: 273496 (cherry picked from commit b7ca0e85105a9ac68a9d9ea1bdac98dfcf766333) graphics/ristretto/Makefile | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)