Created attachment 244633 [details] patch Reasons for the update: 1. The current GL_TAGNAME doesn't match the version 1.4.31. The code is actually for the version 1.4.30. 2. The upstream merged one feature that I particularly need (move mouse pointer when connection is idle), among many other commits. This patch also corrects the git revision in the 'About Remmina' box. It has the backport of the merge request that I've submitted. Thank you, Yuri
Fernando, Please hold on this. There are some issues with this version.
(In reply to Yuri Victorovich from comment #1) Thanks for the patch Yuri, I'll build tests this ASAP
(In reply to Yuri Victorovich from comment #1) While my system rebuilds the dependencies, what problems have you seen in this version?
(In reply to Fernando Apesteguía from comment #3) Remmina SEGVs when user disconnects from the RDP server: https://gitlab.com/Remmina/Remmina/-/issues/2963 I think it's better to hold this until this issue is resolved.
There is also this audio-related regression: https://gitlab.com/Remmina/Remmina/-/issues/2965
Created attachment 245189 [details] Patch to update net/remmina to 1.4.32 Hi Yuri, This is a patch to update net/remmina to 1.4.32. It works for me although I can't test all the options. The About window correctly reports the version number. I needed to cherry pick a commit since Remmina failed to build if the SSH plugin was disabled. Would you have a look?
(In reply to Fernando Apesteguía from comment #6) Hi Fernando, Thanks for the patch. The latest code as of 2-3 weeks ago had 2 regressions with audio not playing in the "Local" mode. So I will hold off with the update for now until I would be able to confirm that these have been fixed. Thanks again, Yuri
I would verify this next week. I use Remmina daily. Thanks, Yuri
(In reply to Fernando Apesteguía from comment #6) Hi Fernando, I retested this version - all problems seem to be gone. Please commit it. Thank you, Yuri
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=629528c3c815c09982c47561439aee67a67b3489 commit 629528c3c815c09982c47561439aee67a67b3489 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-09-22 06:51:47 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-10-03 07:12:05 +0000 net/remmina: update to 1.4.32 Cherry pick upstream commit to allow Remmina to build without the ssh plugin ChangeLog: https://gitlab.com/Remmina/Remmina/-/releases/v1.4.32 * [REM2916] Added option to kill async process started by exec plugin on tab close * Fix search bar toggle behavior * Fix memory leaks * [REM-2920] Password visibility can now be toggled on remmina_message_panels * Remove SSH file paths from remmina file when unchecking box in profile edit * Solved issue #2910 - Added support for IPv6 with fallback to IPv4 for ssh * Fix UI bugs in Remmina Preferences set new password * Fix memory leaks and change GTK critical errors to remmina warnings for null icon autostart file * [REM-2926] Added ability to set a fixed aspect ratio for vnc connections * Fix snap crash * [REM-2936] Fix crash related to unmap events * [REM-2938] Improved ordering of tray icon menu items * Fix memory leaks in remmina_plugin_manager_init with g_free and g_ptr_array_free * Remote assistance * Spelling: Various strings for assistance mode * Fix some compiler warnings * Ability to SPICE connect to unix domain socket * update multi monitor icon * Save toggle options when duplicating connection * Rem 2954 * New feature: Allow user to specify use of modifiers when changing key preferences * [REM-2914] Alert user of unexpected disconnect instead of immediately closing the connection window * Fix Remmina not using @REMMINA_BINARY_PATH@ * Highlight top bar when Grab all keyboard events is enabled * Snapcraft: Allow remmina preferences file to point to symlinked current directory * [REM-2850] Add ability to automatically move mouse to keep RDP connections alive * Allow user to set REMMINA_GIT_REVISION * Remove unnecessary parameters from remmina_public_get_server_port_wrapper * Fix freeze that occurs when loading in python modules properly * [REM-1923] Fix handling of pause break key for RDP connections * [REM-2971] When quiting Remmina from the system tray the are you sure prompt now functions properly PR: 273564 net/remmina/Makefile | 7 +++++-- net/remmina/distinfo | 8 +++++--- 2 files changed, 10 insertions(+), 5 deletions(-)