Bug 273583 - devel/sccache: Support sccache-dist
Summary: devel/sccache: Support sccache-dist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-05 17:19 UTC by Michael Gmelin
Modified: 2023-09-29 08:00 UTC (History)
1 user (show)

See Also:
pizzamig: maintainer-feedback+


Attachments
Patch to support sccache-dist (24.00 KB, patch)
2023-09-05 17:19 UTC, Michael Gmelin
no flags Details | Diff
Updated patch containing pkg-message.in (24.53 KB, patch)
2023-09-14 11:29 UTC, Michael Gmelin
grembo: maintainer-approval? (pizzamig)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer freebsd_triage 2023-09-05 17:19:57 UTC
Created attachment 244664 [details]
Patch to support sccache-dist

Since sccache gained distributed build support, include the feature in the port. Additional patches to Cargo.* make sure that rediss:// (redis over tls) works.

Patch suitable to be applied using `git am`.
Comment 1 Michael Gmelin freebsd_committer freebsd_triage 2023-09-14 11:29:54 UTC
Created attachment 244833 [details]
Updated patch containing pkg-message.in
Comment 2 Luca Pizzamiglio freebsd_committer freebsd_triage 2023-09-16 13:31:45 UTC
It looks good to me.

Where are the crates updated versions in Cargo.toml coming from?
Comment 3 Michael Gmelin freebsd_committer freebsd_triage 2023-09-16 13:51:42 UTC
(In reply to Luca Pizzamiglio from comment #2)

These are taken from my pull request upstream: https://github.com/mozilla/sccache/pull/1875

(opendal update to support rediss:// again (which was lost somewhere between releases, which required to update reqsign and add backon, since opendal forgot to bump minimum versions)
Comment 4 Luca Pizzamiglio freebsd_committer freebsd_triage 2023-09-28 19:00:10 UTC
Please, feel free to commit it!

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-09-29 08:00:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90b1184d93c8af5d6f37605be325f2f2e51e4aa9

commit 90b1184d93c8af5d6f37605be325f2f2e51e4aa9
Author:     Michael Gmelin <grembo@FreeBSD.org>
AuthorDate: 2023-09-05 17:16:06 +0000
Commit:     Michael Gmelin <grembo@FreeBSD.org>
CommitDate: 2023-09-29 07:56:40 +0000

    devel/sccache: Support sccache-dist

    This allows running an sccache build cluster. Also includes patch
    to support redis over tls (rediss://).

    Install more documentation.

    PR:             273583
    Approved by:    pizzamig (maintainer)

 devel/sccache/Makefile                   |  48 +++---
 devel/sccache/distinfo                   |  50 +++----
 devel/sccache/files/patch-Cargo.lock     | 244 ++++++++++++++++++++++++++++++-
 devel/sccache/files/patch-Cargo.toml     |  30 +++-
 devel/sccache/files/pkg-message.in (new) |  11 ++
 5 files changed, 335 insertions(+), 48 deletions(-)