Bug 273729 - textproc/hs-pandoc: Update to 3.1.8
Summary: textproc/hs-pandoc: Update to 3.1.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-11 21:50 UTC by Yuri Victorovich
Modified: 2023-09-17 18:11 UTC (History)
1 user (show)

See Also:
arrowd: maintainer-feedback+


Attachments
patch (52.57 KB, patch)
2023-09-11 21:50 UTC, Yuri Victorovich
no flags Details | Diff
patch (52.98 KB, patch)
2023-09-12 06:42 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2023-09-11 21:50:23 UTC
Created attachment 244778 [details]
patch
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2023-09-12 05:48:44 UTC
Can you please also dump HACKAGE_DISTNAME to 0.1.1.1 ?
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2023-09-12 06:42:43 UTC
Created attachment 244789 [details]
patch

Update HACKAGE_DISTNAME.
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2023-09-12 06:50:24 UTC
LGTM, thanks for working on this! Do the quarterly MFH too, please.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2023-09-12 07:02:11 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-09-12 07:03:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2a7f215060d1a83b635a0bbcf5d759b9884f5b6c

commit 2a7f215060d1a83b635a0bbcf5d759b9884f5b6c
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-09-12 06:57:55 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-09-12 07:02:18 +0000

    textproc/hs-pandoc: update 3.1.2 → 3.1.8

    PR:             273729
    Approved by:    arrowd@ (on behalf of haskell@)

 textproc/hs-pandoc/Makefile  | 130 ++++++++++-----------
 textproc/hs-pandoc/distinfo  | 268 ++++++++++++++++++++++---------------------
 textproc/hs-pandoc/pkg-plist |  13 +--
 3 files changed, 205 insertions(+), 206 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-09-12 07:03:21 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=58b2e5d02ab7aebd6b1152ab05a73436d4cf5f7f

commit 58b2e5d02ab7aebd6b1152ab05a73436d4cf5f7f
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-09-12 06:57:55 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-09-12 07:02:54 +0000

    textproc/hs-pandoc: update 3.1.2 → 3.1.8

    PR:             273729
    Approved by:    arrowd@ (on behalf of haskell@)

    (cherry picked from commit 2a7f215060d1a83b635a0bbcf5d759b9884f5b6c)

 textproc/hs-pandoc/Makefile  | 130 ++++++++++-----------
 textproc/hs-pandoc/distinfo  | 268 ++++++++++++++++++++++---------------------
 textproc/hs-pandoc/pkg-plist |  13 +--
 3 files changed, 205 insertions(+), 206 deletions(-)
Comment 7 Gleb Popov freebsd_committer freebsd_triage 2023-09-17 11:13:34 UTC
After this update the x11/xpra port fails when it calls out to pandoc:

>  This version of pandoc has been compiled without Lua support.

Indeed, your patch removes hslua dependencies from USE_CABAL. Maybe lua support became an option that should be enabled with CABAL_FLAGS? Can you please look into that?
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2023-09-17 16:25:05 UTC
(In reply to Gleb Popov from comment #7)

Pandoc indeed has a "lua" flag, but it is True by default and it didn't change recently.
Project's changelog mentions some Lua changes, but it wasn't related to how it is enabled.

I'll ask the pandoc upstream this question.
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2023-09-17 17:30:58 UTC
Adding CABAL_FLAGS=lua helps. I will commit the fix shortly.

--------------------------------------------------------------

Gleb,

This looks like a bug either in the Haskel support in the ports framework, or in Haskel itself:
The 'lua' flag is defined with the default value 'True'.
But 'make make-use-cabal' doesn't generate dependencies for the Lua support in pandoc without CABAL_FLAGS=lua, as if the 'lua' flag is OFF, despite it being ON by default.
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-09-17 18:10:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ddf4007c38695d6ed924ea751e96ca0da4f39c4

commit 9ddf4007c38695d6ed924ea751e96ca0da4f39c4
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-09-17 18:05:06 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-09-17 18:09:33 +0000

    textproc/hs-pandoc: Enable the 'lua' option

    This option was accidentally disabled during the update to 3.1.8
    due to some glitch in the Haskel support in the ports framework.

    The 'lua' option is ON by default in the project. However, Lua
    dependencies are only added by 'make make-use-cabal' when
    CABAL_FLAGS=lua is present, despite this option being ON by default.

    PR:             273729
    Reported by:    arrowd@

 textproc/hs-pandoc/Makefile |  79 +++++++++++++++++--
 textproc/hs-pandoc/distinfo | 182 +++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 245 insertions(+), 16 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2023-09-17 18:11:01 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fe1dd0c4552c7054c0e7f68fd8fd9e678c89c4a3

commit fe1dd0c4552c7054c0e7f68fd8fd9e678c89c4a3
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-09-17 18:05:06 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-09-17 18:10:02 +0000

    textproc/hs-pandoc: Enable the 'lua' option

    This option was accidentally disabled during the update to 3.1.8
    due to some glitch in the Haskel support in the ports framework.

    The 'lua' option is ON by default in the project. However, Lua
    dependencies are only added by 'make make-use-cabal' when
    CABAL_FLAGS=lua is present, despite this option being ON by default.

    PR:             273729
    Reported by:    arrowd@

    (cherry picked from commit 9ddf4007c38695d6ed924ea751e96ca0da4f39c4)

 textproc/hs-pandoc/Makefile |  79 +++++++++++++++++--
 textproc/hs-pandoc/distinfo | 182 +++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 245 insertions(+), 16 deletions(-)