Bug 273785 - emulators/vice Fails to build
Summary: emulators/vice Fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-14 14:42 UTC by bas
Modified: 2023-11-18 16:47 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+


Attachments
Full build log from my Poudriere env. (27.76 KB, application/x-bzip)
2023-09-14 14:42 UTC, bas
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description bas 2023-09-14 14:42:18 UTC
Created attachment 244841 [details]
Full build log from my Poudriere env.

Point in log file where the build crashes, full log included in attachment.

/wrkdirs/usr/ports/emulators/vice/work/vice-3.7.1/src/arch/shared/iodrv/io-unix-access.c:133:12: fatal error: implicit declaration of function 'inb' is invalid in C99 [-Wimplicit-function-declaration]
    return inb(addr);
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2023-09-14 19:53:23 UTC
Known problem, no fix yet available

The function seem not available on this architecture.

I am not able to test builds for this environment.
Comment 2 bas 2023-09-14 20:50:43 UTC
If it helps, I can give you a jail on my Pi4 where this problem occurs so you can have a look. It's not the fastest of systems but it's what I have. Hunting this one down myself is probably beyond my skill level with C.
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2023-09-22 19:45:14 UTC
It would help to have access:

if all dependencies are installed,
an unprivileged user is sufficient.

Please provide an ssh access for this keys:

https://people.freebsd.org/~dinoex/authorized_keys

Then send me the details in private mail
with the IPv4/IPv6 or hostname and port I can login.

You can limit access from 185.220.148.0/24 or 2a0b:f840::/64
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-10-09 09:03:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0b4ed72cbba69b466a1356ace2c4302de5b57bc6

commit 0b4ed72cbba69b466a1356ace2c4302de5b57bc6
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2023-10-09 09:02:14 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2023-10-09 09:02:14 +0000

    emulators/vice: fix build on arm64

    PR: 273785

 emulators/vice/Makefile                                    |  2 +-
 .../files/patch-src_arch_shared_iodrv_io-unix-access.c     | 14 +++++++++++++-
 2 files changed, 14 insertions(+), 2 deletions(-)
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2023-10-09 09:21:59 UTC
Thanks for the support.

Sadly I was unable to complete the build,
because the build dependencies where not installed.

I tried to build the dependencies, but it failed on rust.

Please try if you can build the package now.
Comment 6 bas 2023-10-09 11:22:42 UTC
On it! Will take a while though.
Comment 7 bas 2023-10-18 12:43:52 UTC
Build is successful for me on aarch64 now.
Comment 8 Dirk Meyer freebsd_committer freebsd_triage 2023-10-24 18:12:01 UTC
Thanks
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-11-18 16:47:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b7f6d468072ef91a66d1ea7d940d5fd37c21bc4

commit 3b7f6d468072ef91a66d1ea7d940d5fd37c21bc4
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2023-11-18 16:45:12 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2023-11-18 16:46:59 +0000

    emulators/vice: fix build on arm64

    PR: 273785

 emulators/vice/Makefile                                   |  2 +-
 .../files/patch-src_arch_shared_iodrv_io-unix-access.c    | 15 +++++++++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)