Building the latest version (4.0.4_1) results in the following packaging error on my poudriere build server: ===> Staging rc.d startup script(s) =========================================================================== =======================<phase: package >============================ ===> Building package for transmission-default-4.0.4_1 pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/transmission/work-default/stage/usr/local/share/doc/transmission/AUTHORS:No such file or directory pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/transmission/work-default/stage/usr/local/share/doc/transmission/COPYING:No such file or directory pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/transmission/work-default/stage/usr/local/share/doc/transmission/README.md:No such file or directory *** Error code 1 Stop. make: stopped in /usr/ports/net-p2p/transmission =>> Cleaning up wrkdir ===> Cleaning for transmission-default-4.0.4_1 build of net-p2p/transmission | transmission-default-4.0.4_1 ended at Fri Sep 22 15:54:36 CEST 2023 build time: 00:31:52 !!! build failure encountered !!! The original 4.0.4 only had 1 file not found, now it's 3 files not found.
Which flavour are you building? What port options are set (run "make showconfig")? I've build-tested this port just yesterday and it built fine for me.
Since I don't know how to run "make showconfig" for a port done by poudriere, I ran de poudriere option to run the config, and noticed there is now more options like GTK and QT. With 4.0.4 I only unselected CLI. Let me rebuild it and see how that goes. I did not expect option changes, hence I didn't re-run that part.
Poudriere should show you the configured options at the top of the build log. I could reproduce the error by deselecting the DOCS option. It seems that the plist unconditionally includes these files. They should be prefixed with %%PORTDOCS%% so they only get installed when DOCS is set. @maintainer, please test build the port with various option combinations. At least test with "all options on" and "all options off." That usually catches most of the issues.
Just to answer the options request: (seems I did have CLI enabled? Pretty sure I unselected it because deprecated) ---Begin OPTIONS List--- ===> The following configuration options are available for transmission-full-4.0.4: CLI=on: Build remote & command-line (deprecated) clients DAEMON=on: Build daemon DOCS=off: Build and/or install documentation NLS=off: Native Language Support TESTS=off: Build & run unit tests UTILS=on: Build utilities (create, edit, show) WEB=on: Install web client ===> Use 'make config' to modify these settings ---End OPTIONS List--- ---Begin OPTIONS List--- ===> The following configuration options are available for transmission-default-4.0.4_1: CLI=off: Build remote & command-line (deprecated) clients DAEMON=on: Build daemon DOCS=off: Build and/or install documentation GTK=on: Build GTK+ client NLS=off: Native Language Support QT=on: Build QT client TESTS=off: Build & run unit tests UTILS=on: Build utilities (create, edit, show) WEB=on: Install web client (imples daemon) ===> Use 'make config' to modify these settings ---End OPTIONS List---
Created attachment 245122 [details] transmission_2 Thank you for reporting this. The attached patch fixes the error.
Don't think the PORTREVISION bump is necessary. Attached patch fixed build for me with DOCS=off.
Created attachment 245155 [details] transmission_2 What's the policy on port version bumps? It's not every iteration?
(In reply to Rafe from comment #7) > What's the policy on port version bumps? It's not every iteration? 1. Fixed bugs in software - added patches. 2. Changed default build options. 3. The libs that the port depends on have been updated.with "so" version bump. 4. The build process has changed/fixed so that the result has changed. But if the port could not be compiled and it was fixed, then there is no point in a bump - there was no previous version anyway.
(In reply to Vladimir Druzenko from comment #8) Got it, thanks!
(In reply to Tom Weustink from comment #2) > Since I don't know how to run "make showconfig" for a port done by poudriere Same as you do configuring, just add "-s" without quotes, like "poudriere options -s [-n] net-p2p/transmission"
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1ee58e3d9f0325a2d6e19d8ea8b1608d9d03caed commit 1ee58e3d9f0325a2d6e19d8ea8b1608d9d03caed Author: Rafe <mondo.debater_0q@icloud.com> AuthorDate: 2023-09-22 16:57:18 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-09-24 18:57:14 +0000 net-p2p/transmission: Fix pkg-plist.default This fixes a plist issue when the port is built in default flavour with DOCS disabled. PR: 274025 Reported by: t.weustink@outlook.com net-p2p/transmission/pkg-plist.default | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Thank you for your contribution.