Bug 274043 - net-im/telegram-desktop: fails to build with glibmm26-2.78
Summary: net-im/telegram-desktop: fails to build with glibmm26-2.78
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-23 09:44 UTC by Anton Saietskii
Modified: 2023-09-25 20:24 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-09-23 09:44:40 UTC
/usr/local/libexec/ccache/c++ -DCRL_USE_COMMON_QUEUE -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_DISABLE_WAYLAND_INTEGRATION -DDESKTOP_APP_USE_PACKAGED -DGI_INLINE -DGI_OBJECT_NEWV -DKCOREADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x051500 -DQT_GUI_LIB -DQT_IMPLICIT_QCHAR_CONSTRUCTION -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_QUICKWIDGETS_LIB -DQT_QUICK_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -I/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_base -I/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_rpl -I/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_crl -I/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/cmake/external/glib/cppgir -I/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/cmake/external/glib/cppgir/gi -I/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/cmake/external/glib/cppgir/override -I/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/cmake/external/glib/cppgir/expected-lite/include -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-clang -isystem /usr/local/include/qt5/QtCore/5.15.8 -isystem /usr/local/include/qt5/QtCore/5.15.8/QtCore -isystem /usr/local/include/qt5/QtGui -isystem /usr/local/include/qt5/QtGui/5.15.8 -isystem /usr/local/include/qt5/QtGui/5.15.8/QtGui -isystem /usr/local/include/qt5/QtWidgets -isystem /usr/local/include/qt5/QtWidgets/5.15.8 -isystem /usr/local/include/qt5/QtWidgets/5.15.8/QtWidgets -isystem /usr/local/include/qt5/QtNetwork -isystem /usr/local/include/qt5/QtSvg -isystem /usr/local/include/qt5/QtDBus -isystem /usr/local/include/qt5/QtQml -isystem /usr/local/include/qt5/QtQuick -isystem /usr/local/include/qt5/QtQmlModels -isystem /usr/local/include/qt5/QtQuickWidgets -isystem /usr/local/share -isystem /usr/local/include/giomm-2.68 -isystem /usr/local/lib/giomm-2.68/include -isystem /usr/local/include/glib-2.0 -isystem /usr/local/lib/glib-2.0/include -isystem /usr/local/include/glibmm-2.68 -isystem /usr/local/lib/glibmm-2.68/include -isystem /usr/local/include/sigc++-3.0 -isystem /usr/local/lib/sigc++-3.0/include -isystem /usr/local/include/KF5/KCoreAddons -isystem /usr/local/include/KF5 -isystem /wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/.build/Telegram/lib_base/gen -isystem /wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/.build/gen -isystem /usr/local/include/gio-unix-2.0 -O3 -pipe -march=native  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing   -isystem /usr/local/include -std=c++17 -O3 -pipe -march=native  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing   -isystem /usr/local/include -std=c++17  -DNDEBUG -std=gnu++20 -fPIC -fno-strict-aliasing -pipe -Wall -Wextra -Wno-unused-parameter -Wno-switch -Wno-missing-field-initializers -Wno-sign-compare -Wno-deprecated -pthread -Winvalid-pch -Xclang -include-pch -Xclang /wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/.build/Telegram/lib_base/CMakeFiles/lib_base.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/.build/Telegram/lib_base/CMakeFiles/lib_base.dir/cmake_pch.hxx -MD -MT Telegram/lib_base/CMakeFiles/lib_base.dir/base/platform/linux/base_last_input_linux.cpp.o -MF Telegram/lib_base/CMakeFiles/lib_base.dir/base/platform/linux/base_last_input_linux.cpp.o.d -o Telegram/lib_base/CMakeFiles/lib_base.dir/base/platform/linux/base_last_input_linux.cpp.o -c /wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_base/base/platform/linux/base_last_input_linux.cpp
In file included from /wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_base/base/platform/linux/base_last_input_linux.cpp:10:
/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_base/base/platform/linux/base_linux_glibmm_helper.h:22:7: error: redefinition of 'Variant<long long>'
class Variant<Int64Helper> : public VariantBase {
      ^~~~~~~~~~~~~~~~~~~~
/usr/local/include/glibmm-2.68/glibmm/variant_basictypes.h:735:18: note: previous definition is here
class GLIBMM_API Variant<long long> : public VariantBase
                 ^
In file included from /wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_base/base/platform/linux/base_last_input_linux.cpp:10:
/wrkdirs/usr/ports/net-im/telegram-desktop/work-qt5/tdesktop-4.8.4-full/Telegram/lib_base/base/platform/linux/base_linux_glibmm_helper.h:66:7: error: redefinition of 'Variant<unsigned long long>'
class Variant<UInt64Helper> : public VariantBase {
      ^~~~~~~~~~~~~~~~~~~~~
/usr/local/include/glibmm-2.68/glibmm/variant_basictypes.h:778:18: note: previous definition is here
class GLIBMM_API Variant<unsigned long long> : public VariantBase
                 ^
2 errors generated.
ninja: build stopped: subcommand failed.
*** Error code 1

Stop.
make: stopped in /usr/ports/net-im/telegram-desktop

This happens right away after 2bc4f4638ccce57a9011513a2a8396b84aea59c7.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-09-23 15:04:31 UTC
^Triage: with no maintainer but known regressing commit CC'ing the responsible for clues. pkg-fallout@ didn't complain yet as https://pkg-status.freebsd.org/builds/default:default:132amd64:f16b003f6abd:beefy16#new_failed hasn't finished.
Comment 2 Dima Panov freebsd_committer freebsd_triage 2023-09-25 13:19:47 UTC
WIP
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-09-25 15:09:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6a6a9ad85d351525e0a974e5e9ae36a30b30155a

commit 6a6a9ad85d351525e0a974e5e9ae36a30b30155a
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2023-09-25 15:08:32 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2023-09-25 15:08:32 +0000

    net-im/telegram-desktop: update to 4.9.3 release (+)

    Telegram Desktop 4.9.3 is latest release which supports Qt 5.15.8 before migrating to Qt 5.15.10 API

    PR:     274043, 274064

 net-im/telegram-desktop/Makefile                        | 12 +++---------
 net-im/telegram-desktop/distinfo                        |  6 +++---
 ...inux_base__system__media__controls__linux.cpp (gone) | 17 -----------------
 ...tch-cmake_external_glib_cppgir_CMakeLists.txt (gone) | 13 -------------
 ...h-cmake_external_glib_cppgir_tools_cppgir.cpp (gone) | 13 -------------
 ...cmake_external_glib_cppgir_tools_function.hpp (gone) |  8 --------
 ...-cmake_external_glib_cppgir_tools_genbase.cpp (gone) |  8 --------
 ...ch-cmake_external_glib_cppgir_tools_genns.cpp (gone) | 13 -------------
 net-im/telegram-desktop/pkg-plist                       |  1 +
 9 files changed, 7 insertions(+), 84 deletions(-)
Comment 4 Anton Saietskii 2023-09-25 16:59:56 UTC
Dima, may I ask you if a patch has been written without looking @ bug #274064 or you just forgot to list me as a patch author? Thanks in advance!
Comment 5 Dima Panov freebsd_committer freebsd_triage 2023-09-25 17:59:43 UTC
(In reply to Anton Saietskii from comment #4)
It was prepared earlier while playing with recent releases of tdesktop and qt5.15.10 and downgraded to 4.9.3 just for fix build error in repo. 

However, qt5 was just bumped and I'll push a more recent tg release in da ports asap
Comment 6 Dima Panov freebsd_committer freebsd_triage 2023-09-25 18:01:52 UTC
(In reply to Anton Saietskii from comment #4)
Just got a look over your patch in mentioned PR. 
It is still incomplete, just compare with committed version.
Comment 7 Anton Saietskii 2023-09-25 18:15:38 UTC
(In reply to Dima Panov from comment #6)

Yes, it's not complete. Just curious whether my newb ugly patch was used as a base for commit.

Regarding playing (though I would call this "suffering") with new versions — if you will be in mood to continue this, then I would like to ask to push whatever new version ASAP, e.g. "we have 4.8.4, latest is 4.10.1, but we can push only 4.9.3 — let's just push 4.9.3 right away and not wait until 4.10.1 will be possible".
(Yes, port is officially unmaintained currently, that's why I tried to write my own patch.)
Comment 8 Dima Panov freebsd_committer freebsd_triage 2023-09-25 20:24:32 UTC
(In reply to Anton Saietskii from comment #7)
Port assigned to ports but still curated by osa@ and me :)
Feel free to ping us with future requests.

About future tdesktop releases. Qt5.15.10.p31 just hits the ports, and I'll bump port again asap.