Bug 274150 - devel/schilybase: fix build with lld 17
Summary: devel/schilybase: fix build with lld 17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL: https://codeberg.org/schilytools/schi...
Keywords:
Depends on:
Blocks: 273753
  Show dependency treegraph
 
Reported: 2023-09-28 18:38 UTC by Dimitry Andric
Modified: 2023-09-30 20:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (fuz)


Attachments
devel/schilybase: fix build with lld 17 (877 bytes, patch)
2023-09-28 18:38 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-09-28 18:38:03 UTC
Building devel/schilybase with lld 17 results in the following link errors:

        ==> LINKING dynamic library "../libs/amd64-freebsd-clang/pic/libschily.so.2.0"
ld: error: version script assignment of 'SCHILY_1.0' to symbol 'getdomainname' failed: symbol not defined
ld: error: version script assignment of 'SCHILY_1.6' to symbol 'qftoes' failed: symbol not defined
ld: error: version script assignment of 'SCHILY_1.6' to symbol 'qftofs' failed: symbol not defined
cc: error: linker command failed with exit code 1 (use -v to see invocation)

The symbols in question are not always defined. getdomainname() is only defined when HAVE_GETDOMAINNAME is undefined, and qftoes() and qftofs() are only defined when HAVE_LONGDOUBLE is undefined. Add #ifndef blocks to libschily/libschily-mapvers to handle these.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-09-28 18:38:26 UTC
Created attachment 245314 [details]
devel/schilybase: fix build with lld 17
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-09-28 18:41:52 UTC
Thank you for the report.

Your patch looks reasonable.

I will fix this upstream and prepare a new release with the fix.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-09-28 18:55:51 UTC
Your change has been pushed upstream to fix this.

https://codeberg.org/schilytools/schilytools/commit/5bdcd30d229e8158bd95da260f8e15c446bd12f6

I will after testing prepare a new release to address your issue.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-09-28 19:53:45 UTC
A new release 2023-09-28 has been pushed.  I hope I can get it in the tree before the 2023Q4 changeover.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-09-30 20:01:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f70bee31fbc0f15c0d9ed8839ff84a28abbb7afd

commit f70bee31fbc0f15c0d9ed8839ff84a28abbb7afd
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-09-29 19:06:40 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-30 20:00:01 +0000

    devel/schilybase: update to 2023-09-27

    This fixes a link issue with lld 17.

    Changelog: http://fuz.su/pub/schilytools/AN-2023-09-28.txt

    PR:             274150
    Reported by:    dim

 devel/schilybase/Makefile.master | 2 +-
 devel/schilybase/distinfo        | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-09-30 20:03:49 UTC
Thank you for your report.