Created attachment 245373 [details] yadifa 2.6.5 Yadifa 2.6.5 was released; this git diff patch does accordingly. Tested all fine with Poudriere.
Hello Leo, I've found a build failure and plist issues: CTRL=on: Remote control DDNS=off: Dynamic DNS support (DDNS) DNSSECTOOLS=off: DNSSEC module DOCS=off: Build and/or install documentation ECDSA=off: Elliptic Curve (ECDSA) EXAMPLES=off: Build and/or install examples KEYGEN=off: Keygen tool LARGEFILE=off: Support for largefiles MASTER=off: Use as primary nameserver NSID=off: Name Server Identifier Option RRL=off: Response Rate Limiting RRSIG=off: RRSIG management TCL=off: Tcl scripting language support ZONESIGN=off: Zonesign tool --- database.o --- depbase=`echo database.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc -DHAVE_CONFIG_H -I. -I../.. -D_THREAD_SAFE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -I/wrkdirs/usr/ports/dns/yadifa/work/yadifa-2.6.5-11201/sbin/yadifad -I/wrkdirs/usr/ports/dns/yadifa/work/yadifa-2.6.5-11201/sbin/yadifad/include -I/wrkdirs/usr/ports/dns/yadifa/work/yadifa-2.6.5-11201/sbin/yadifad/include -fno-ident -ansi -pedantic -Wall -Wno-unknown-pragmas -Werror=missing-field-initializers -std=gnu11 -mtune=native -DUSES_LLVM -Wno-gnu -I./include -DPREFIX='"/usr/local"' -DSYSCONFDIR='"/usr/local/etc"' -DLOCALSTATEDIR='"/var"' -DDATAROOTDIR='"/usr/local/share"' -DDATADIR='"/usr/local/share"' -DLOCALEDIR='"/usr/local/share/locale"' -DLOGDIR='"/var/log/yadifa"' -DTCLDIR='""' -I../../lib/dnscore/include -I../../lib/dnscore/include -I../../lib/dnsdb/include -I../../lib/dnsdb/include -I../../lib/dnstcl/include -I../../lib/dnstcl/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -MT database.o -MD -MP -MF $depbase.Tpo -c -o database.o database.c && mv -f $depbase.Tpo $depbase.Po --- database-service-zone-load.o --- 1 error generated. *** [database-service-zone-load.o] Error code 1 make[4]: stopped in /wrkdirs/usr/ports/dns/yadifa/work/yadifa-2.6.5-11201/sbin/yadifad --- database-service-zone-store.o --- 3 warnings generated. 1 error ========== CTRL=on: Remote control DDNS=on: Dynamic DNS support (DDNS) DNSSECTOOLS=on: DNSSEC module DOCS=on: Build and/or install documentation ECDSA=on: Elliptic Curve (ECDSA) EXAMPLES=on: Build and/or install examples KEYGEN=on: Keygen tool LARGEFILE=on: Support for largefiles MASTER=on: Use as primary nameserver NSID=on: Name Server Identifier Option RRL=on: Response Rate Limiting RRSIG=on: RRSIG management TCL=off: Tcl scripting language support ZONESIGN=on: Zonesign tool ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: bin/%%USERS%% ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. ===== Could you take a look at it?
(In reply to Nuno Teixeira from comment #1) > Could you take a look at it? ACK, will try to replicate that error (which I didn't got).
Created attachment 245860 [details] yadifa 2.6.5 bis I'm unable to replicate the error, and I don't understand how that's even possible: as far as I'm aware of there are no partial dynamic plist additions based on options, and so I think an "bin/bla" is odd - it only should have "sbin/bla's". However, I did spot superfluous LDFLAGS parameters, so by these an improved patch, which (again) works perfectly fine when I test it in my Poudriere. And so I'm curious if this solves it in your testing (and gladly learn if I could do my tests better).
(In reply to Leo Vandewoestijne from comment #3) Did try latest patch with poudriere on a 13.2 jail and found build failure with CTRL=on and all other options OFF, It sugests that maybe CTRL option might have dependency on other option: --- In file included from database-service-zone-load.c:93: ./database-service-zone-resignature.h:83:2: error: "no RRSIG management support: database-service-zone-resignature.h should not be included" #error "no RRSIG management support: database-service-zone-resignature.h should not be included" --- PlIST issue remains when CTRL=on and rest default options: --- ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: bin/%%USERS%% --- Are you running `poudriere testport -c -j JAIL -p PORTS dns/yadifa`? ----^
Created attachment 245880 [details] yadifa 2.6.5 bis bis (In reply to Nuno Teixeira from comment #4) The -c option I indeed didn't really know. It showed me the problem, and allowed me to do trail & error puzzling. And so I discovered cascading options. CTRL commands requires to compile as a master - which is odd IMHO. Also I regret that euRid does not seem to make the CTRL DNS queries an IETF RFC. Anyway, with this patch I cannot spot any error anymore.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bd99b337f0bb15f1661babaa8196331f0dbf915a commit bd99b337f0bb15f1661babaa8196331f0dbf915a Author: Leo Vandewoestijne <freebsd@dns.company> AuthorDate: 2023-10-27 07:53:14 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-10-27 07:55:20 +0000 dns/yadifa: Update to 2.6.5 ChangeLog: https://www.yadifa.eu/sites/default/files/README_2.6.5.txt PR: 274210 dns/yadifa/Makefile | 10 +++++----- dns/yadifa/distinfo | 6 +++--- dns/yadifa/pkg-plist | 1 + 3 files changed, 9 insertions(+), 8 deletions(-)
Nice work on fix! Committed, thanks.